Skip to content

OSDOCS-8836: bug fix add Service field to proxy config #68465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2023
Merged

OSDOCS-8836: bug fix add Service field to proxy config #68465

merged 1 commit into from
Nov 29, 2023

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Nov 28, 2023 •
edited
Loading

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-8836

Link to docs preview:
MicroShift CRI-O container runtime settings
Using rpm-ostree proxy settings

QE review:

  • QE has approved this change.

Additional information:
Customer case resolution, see Issue for links and details

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

@ShaunaDiaz: This pull request references OSDOCS-8836 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-8836

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Customer case resolution

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 28, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://68465--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/34983

@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-8836 branch 2 times, most recently from f86e03f to cdc7653 Compare November 28, 2023 15:03
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-8836 branch 2 times, most recently from 91139ff to b818169 Compare November 28, 2023 17:17
@dhensel-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 28, 2023
@ShaunaDiaz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 28, 2023
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 28, 2023
@mburke5678
Copy link
Contributor

@ShaunaDiaz One nit. Otherwise LGTM

@ShaunaDiaz
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 29, 2023
jldohmann
jldohmann approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jldohmann jldohmann added this to the Continuous Release milestone Nov 29, 2023
@jldohmann jldohmann merged commit d4abdae into openshift:main Nov 29, 2023
@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.14

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 29, 2023
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #68595

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #68596

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@dhensel-rh dhensel-rh dhensel-rh left review comments

@jldohmann jldohmann jldohmann approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @dhensel-rh @mburke5678 @jldohmann @openshift-cherrypick-robot