Skip to content

[OSDOCS-9232]: Issue in file rosa_hcp/rosa-tuning-config.adoc #69866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2024
Merged

[OSDOCS-9232]: Issue in file rosa_hcp/rosa-tuning-config.adoc #69866

merged 1 commit into from
Jan 5, 2024

Conversation

mletalie
Copy link
Contributor

@mletalie mletalie commented Jan 5, 2024 •
edited
Loading

Version(s):

4.14+
Issue:

https://issues.redhat.com/browse/OSDOCS-9232
Link to docs preview:

https://69866--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-tuning-config#custom-tuning-specification_rosa-tuning-config
QE review:

  • QE has approved this change.

Additional information:

Image taken from updated (preview) docs. The numbered list did not reflect what was being shown within JSON file (#1 and #2 were reversed).
image

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Jan 05 14:55:14 - Prow CI generated the docs preview: https://69866--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 5, 2024

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mletalie mletalie changed the title reorder list items per ticket [OSDOCS-9232]: Issue in file rosa_hcp/rosa-tuning-config.adoc Jan 5, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Jan 5, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 5, 2024
@kowen-rh
Copy link
Contributor

kowen-rh commented Jan 5, 2024

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 5, 2024
kowen-rh
kowen-rh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@kowen-rh kowen-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 5, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Jan 5, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 5, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 5, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Jan 5, 2024
@stevsmit stevsmit added branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jan 5, 2024
@stevsmit stevsmit merged commit da2200c into openshift:main Jan 5, 2024
@stevsmit
Copy link
Member

stevsmit commented Jan 5, 2024

/cherry-pick enterprise-4.14

@stevsmit
Copy link
Member

stevsmit commented Jan 5, 2024

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #69879

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #69880

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowen-rh kowen-rh kowen-rh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
5 participants
@mletalie @ocpdocs-previewbot @kowen-rh @stevsmit @openshift-cherrypick-robot