Skip to content

OSDOCS-8210: Created an OCI doc book for the AI install route #69901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

OSDOCS-8210: Created an OCI doc book for the AI install route #69901

merged 1 commit into from
Feb 16, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jan 8, 2024 •
edited
Loading

Version(s):
4.15

Issue:
OSDOCS-8210

Link to docs preview:

SME review:
[x]

QE review:
[x]

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2024 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-8210 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2024 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-8210 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-8210

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-8210 branch 4 times, most recently from 262b344 to 992eb10 Compare January 8, 2024 16:54
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-8210 branch 14 times, most recently from 097fa18 to 7e48a6c Compare January 9, 2024 12:49
@dfitzmau dfitzmau changed the title OSDOCS-8210: Crated an OCI doc book for the AI install route OSDOCS-8210: Created an OCI doc book for the AI install route Jan 9, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-8210 branch 2 times, most recently from 4b310b7 to 57f1f37 Compare January 9, 2024 14:34
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 9, 2024 •
edited
Loading

🤖 Fri Feb 16 08:58:29 - Prow CI generated the docs preview: https://69901--ocpdocs-pr.netlify.app

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 15, 2024
@dfitzmau dfitzmau mentioned this pull request Feb 15, 2024
Merged
2 tasks
GroceryBoyJr
GroceryBoyJr reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few small nits. Excellent work @dfitzmau

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 15, 2024

New changes are detected. LGTM label has been removed.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 15, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-8210 branch 2 times, most recently from 03a99a7 to 7c82758 Compare February 15, 2024 19:48
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 15, 2024
@stevsmit stevsmit added this to the Planned for 4.15 GA milestone Feb 15, 2024
stevsmit
stevsmit reviewed Feb 15, 2024
View reviewed changes
modules/installing-troubleshooting-assisted-installer-oci.adoc Outdated
[discrete]
== The Ingress Load Balancer in OCI is not at a healthy status

This issue is classed as a `Warning` as against an `Error`, because by using the Resource Manager to create a stack, you created a pool of compute nodes, 3 by default, that are automatically added as backend listeners for the Ingress Load Balancer. By default, the {product-title} deploys two router pods, which are based on the default values from the {product-title} manifest files. The `Warning` is expected because a mismatch exists with the number of router pods available, two, to run on the three compute nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is confusing: This issue is classed as a Warning as against an Error, because . . .

Maybe it needs revised?

Also, I think it's ok to use either "2" or "two", but you have "3" written as a numeral AND spell it out, and you spell out two each time. Maybe we want to be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "as against an Error". Does this work for you?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 16, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 82e86a3 into openshift:main Feb 16, 2024
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #71737

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 16, 2024
Merged
@mburke5678 mburke5678 mentioned this pull request Mar 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil left review comments

@yobshans yobshans yobshans left review comments

@apinnick apinnick apinnick left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@stevsmit stevsmit stevsmit left review comments

@tshwartz tshwartz tshwartz left review comments

Assignees

@adriengentil adriengentil

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.15 GA
Development

Successfully merging this pull request may close these issues.
10 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @yobshans @adriengentil @GroceryBoyJr @stevsmit @openshift-cherrypick-robot @apinnick @tshwartz