Skip to content

OSDOCS-7078: add ingress dash #71012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

OSDOCS-7078: add ingress dash #71012

merged 1 commit into from
Feb 5, 2024

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Jan 30, 2024 •
edited
Loading

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-7078

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@jldohmann jldohmann added this to the Planned for 4.15 GA milestone Jan 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7078 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-7078

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7078 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-7078

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 30, 2024 •
edited
Loading

🤖 Mon Feb 05 19:20:26 - Prow CI generated the docs preview: https://71012--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2024
@jldohmann
Copy link
Contributor Author

@jotak @frobware could either of you PTAL at this docs PR for updating Network Observability docs to include Ingress dash? Thank you

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2024
@jldohmann
Copy link
Contributor Author

@ShudiLi could you PTAL at this docs PR for QE ack? This adds Ingress dashboard information to Network Observability docs. thank you 🙇

@jotak
Copy link

jotak commented Feb 1, 2024 •
edited
Loading

cc @OlivierCazade who did the development

@frobware
Copy link

frobware commented Feb 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@OlivierCazade
Copy link

/lgtm
Thanks!

@ShudiLi
Copy link
Member

ShudiLi commented Feb 2, 2024

/lgtm
Thanks

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7078 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-7078

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 5, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Feb 5, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 5, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Feb 5, 2024

Preview link: Ingress Operator dashboard

skopacz1
skopacz1 reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor suggestions but otherwise looks great!

@skopacz1
Copy link
Contributor

skopacz1 commented Feb 5, 2024

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 5, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jldohmann jldohmann merged commit fe4d8cd into openshift:main Feb 5, 2024
@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #71218

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2024
Merged
@jldohmann jldohmann deleted the OSDOCS-7078 branch February 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

Assignees

@frobware frobware

@OlivierCazade OlivierCazade

@ShudiLi ShudiLi

Labels
branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.15 GA
Development

Successfully merging this pull request may close these issues.
9 participants
@jldohmann @openshift-ci-robot @ocpdocs-previewbot @jotak @frobware @OlivierCazade @ShudiLi @skopacz1 @openshift-cherrypick-robot