Skip to content

correct documented 'git clone' behaviour #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

jim-minter
Copy link

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2018
@jim-minter
Copy link
Author

@bmcelvee @bparees @mfojtik fyi

@bparees
Copy link
Contributor

bparees commented Jan 11, 2018

lgtm

commit on the default branch (typically `master`) are downloaded. This results
in repositories downloading faster, but without the full commit history. To
perform a full `git clone` of the default branch of a specified repository, set
`ref` to the name of the default branch (e.g. `master`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/e.g./for example,

Unfortunately our style guide doesn't allow for Latin abbreviations. 😿

@bmcelvee
Copy link
Contributor

Just one tiny nit. Otherwise, LGTM! Is this going into 3.5 forward?

@jim-minter
Copy link
Author

Updated - although I note that our docs do already contain a great deal of i.e., e.g. and etc., not to mention a few vs...

@jim-minter
Copy link
Author

3.5+ would be great.

@bparees
Copy link
Contributor

bparees commented Jan 19, 2018

@bmcelvee bump

@bmcelvee bmcelvee added this to the Next Release milestone Jan 19, 2018
@bmcelvee bmcelvee merged commit d286771 into openshift:master Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Jan 19, 2018
@bmcelvee
Copy link
Contributor

[rev_history]
|xref:../dev_guide/builds/build_inputs.adoc#dev-guide-build-inputs[Build Inputs]
|Updated git clone behavior in the xref:../dev_guide/builds/build_inputs.adoc#source-code[Git Source] section.
%

@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published 25/Jan/2018 Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants