Skip to content

OCPBUGS#24512: Minor doc updates #71281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 7, 2024

🤖 Wed Feb 07 10:44:51 - Prow CI generated the docs preview: https://71281--ocpdocs-pr.netlify.app

@sr1kar99 sr1kar99 force-pushed the OCPBUGS_24512_minor_updates branch 2 times, most recently from 24cae93 to 219dcb4 Compare February 7, 2024 09:26
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Feb 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 7, 2024
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 7, 2024
@xenolinux
Copy link
Contributor

xenolinux commented Feb 7, 2024

One nit otherwise LGTM

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 7, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@@ -6,9 +6,9 @@
[id="lvms-unsupported-devices_{context}"]
= Devices not supported by {lvms}

When you are adding the paths to the devices in the `deviceSelector` section of the `LVMCluster` YAML, ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, then {lvms} excludes the devices to avoid complexity in managing logical volumes.
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` cusotm resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` cusotm resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes.
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` custom resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix: typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, @xenolinux!
Fixed the typo.

@sr1kar99 sr1kar99 force-pushed the OCPBUGS_24512_minor_updates branch from 219dcb4 to 8b6e1fd Compare February 7, 2024 10:40
Copy link

openshift-ci bot commented Feb 7, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Feb 7, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 7, 2024
@adellape adellape self-assigned this Feb 7, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 7, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 7, 2024
@adellape adellape merged commit 779ec1c into openshift:main Feb 7, 2024
@adellape
Copy link
Contributor

adellape commented Feb 7, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@adellape: new pull request created: #71327

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants