-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS#24512: Minor doc updates #71281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Wed Feb 07 10:44:51 - Prow CI generated the docs preview: https://71281--ocpdocs-pr.netlify.app |
24cae93
to
219dcb4
Compare
/label peer-review-needed |
/label peer-review-in-progress |
One nit otherwise LGTM /remove-label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit
@@ -6,9 +6,9 @@ | |||
[id="lvms-unsupported-devices_{context}"] | |||
= Devices not supported by {lvms} | |||
|
|||
When you are adding the paths to the devices in the `deviceSelector` section of the `LVMCluster` YAML, ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, then {lvms} excludes the devices to avoid complexity in managing logical volumes. | |||
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` cusotm resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` cusotm resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes. | |
When you are adding the device paths in the `deviceSelector` field of the `LVMCluster` custom resource (CR), ensure that the devices are supported by {lvms}. If you add paths to the unsupported devices, {lvms} excludes the devices to avoid complexity in managing logical volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, @xenolinux!
Fixed the typo.
219dcb4
to
8b6e1fd
Compare
@sr1kar99: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label merge-review-needed |
/cherrypick enterprise-4.15 |
@adellape: new pull request created: #71327 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.15
Issue:
OCPBUGS-24512
Link to docs preview:
https://71281--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms#lvms-unsupported-devices_logical-volume-manager-storage