[OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71418

SNiemann15 · 2024-02-09T13:14:10Z

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-7500

Link to docs preview: https://71418--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-bare-metal

QE review:

QE has approved this change.

Additional information: related to this PR: #71394

ocpdocs-previewbot · 2024-02-09T13:17:47Z

🤖 Fri Feb 09 14:52:48 - Prow CI generated the docs preview: https://71418--ocpdocs-pr.netlify.app

openshift-ci · 2024-02-09T14:54:49Z

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

prb112 · 2024-02-09T15:08:57Z

...on/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-bare-metal.adoc

 include::_attributes/common-attributes.adoc[]

 toc::[]

-To create a cluster with multi-architecture compute machines on bare metal, you must have an existing single-architecture bare metal cluster. For more information on bare metal installations, see xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ARM compute machines to your {product-title} cluster on bare metal.
+To create a cluster with multi-architecture compute machines on bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:


Left comment directly with Alisha

Concerned about implications of supported architecture pairs

@prb112 We have an extra PR from @kelbrown20 with a table to visualize what's possible. See here: #71394
We probably need to further refine the table. Feel free to comment there.

Oh - that's fantastic!

prb112 · 2024-02-09T15:13:13Z

...on/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-bare-metal.adoc


-Before you can add 64-bit ARM nodes to your bare metal cluster, you must upgrade your cluster to one that uses the multi-architecture payload. For more information on migrating to the multi-architecture payload, see xref:../../updating/updating_a_cluster/migrating-to-multi-payload.adoc#migrating-to-multi-payload[Migrating to a cluster with multi-architecture compute machines].
+* xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ARM compute machines to your {product-title} cluster on bare metal.


Suggested change

* xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ARM compute machines to your {product-title} cluster on bare metal.

* xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ppc64le or s390x compute machines to your {product-title} cluster on bare metal.

Is that what's intended?

arm isn't supported with power,s390x

yes arm compute node is only supported with bare metal

SNiemann15 · 2024-02-09T16:09:59Z

...on/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-bare-metal.adoc

 include::_attributes/common-attributes.adoc[]

 toc::[]

-To create a cluster with multi-architecture compute machines on bare metal, you must have an existing single-architecture bare metal cluster. For more information on bare metal installations, see xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ARM compute machines to your {product-title} cluster on bare metal.
+To create a cluster with multi-architecture compute machines on bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:


@prb112 Does adding "either" make it more clear?

Suggested change

To create a cluster with multi-architecture compute machines on bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:

To create a cluster with multi-architecture compute machines on either bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:

Yes. That's much clearer.

alishaIBM · 2024-02-13T11:15:05Z

/assign @prb112

holgwolf · 2024-02-14T18:24:43Z

LGTM

prb112

/lgtm

SNiemann15 · 2024-02-15T15:40:46Z

/label peer-review-needed

SNiemann15 · 2024-02-15T15:45:10Z

/label multi-arch

skrthomas

One small comment that applies globally, but lgtm otherwise.

skrthomas · 2024-02-15T18:59:50Z

...ion/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-ibm-power.adoc

@@ -15,6 +15,13 @@ Before you can add `ppc64le` nodes to your cluster, you must upgrade your cluste

 The following procedures explain how to create a {op-system} compute machine using an ISO image or network PXE booting. This will allow you to add `ppc64le` nodes to your cluster and deploy a cluster with multi-architecture compute machines.

+[NOTE]
+====
+To create an {ibm-power-name} (`ppc64le`) cluster with multi-architecture compute machines on `x86_64`, follow the instructions for


Suggested change

To create an {ibm-power-name} (`ppc64le`) cluster with multi-architecture compute machines on `x86_64`, follow the instructions for

To create an {ibm-power-name} (`ppc64le`) cluster with multiarchitecture compute machines on `x86_64`, follow the instructions for

This was brought up to me in another peer review but aparently most words beginning with multi are not supposed to by hypenated. I know there are multiple instances of this in the repo as "multi-architecture" Here's the IBMSG info:
https://www.ibm.com/docs/en/ibm-style?topic=grammar-prefixes

Multi-architecture compute is a fixed term for this feature.
I assume that spelling was agreed on when this feature was introduced.
@kelbrown20 Is this something we should add to the SSG?

SNiemann15 · 2024-02-16T07:12:14Z

/label merge-review-needed

SNiemann15 · 2024-02-16T08:07:47Z

/label merge-review-needed

snarayan-redhat · 2024-02-16T09:50:45Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-02-16T09:51:33Z

@snarayan-redhat: new pull request created: #71723

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2024

SNiemann15 force-pushed the ibmpz_control_plane branch from eb29b16 to f6aa844 Compare February 9, 2024 14:31

multi-architecture instructions for power and z control planes

7051b9a

SNiemann15 force-pushed the ibmpz_control_plane branch from f6aa844 to 7051b9a Compare February 9, 2024 14:47

prb112 reviewed Feb 9, 2024

View reviewed changes

SNiemann15 commented Feb 9, 2024

View reviewed changes

openshift-ci bot assigned prb112 Feb 13, 2024

werled approved these changes Feb 13, 2024

View reviewed changes

prb112 approved these changes Feb 15, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 15, 2024

openshift-ci bot added the multi-arch Label for all IBM Power and Z PRs label Feb 15, 2024

skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 15, 2024

skrthomas reviewed Feb 15, 2024

View reviewed changes

skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 15, 2024

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 16, 2024

snarayan-redhat removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 16, 2024

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 16, 2024

snarayan-redhat removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 16, 2024

snarayan-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.15 labels Feb 16, 2024

snarayan-redhat added this to the Planned for 4.15 GA milestone Feb 16, 2024

snarayan-redhat merged commit 83b3175 into openshift:main Feb 16, 2024

openshift-cherrypick-robot mentioned this pull request Feb 16, 2024

[enterprise-4.15] [OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71723

Merged

snarayan-redhat removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 16, 2024

SNiemann15 deleted the ibmpz_control_plane branch February 16, 2024 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71418

[OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71418

SNiemann15 commented Feb 9, 2024 •

edited

Loading

ocpdocs-previewbot commented Feb 9, 2024 •

edited

Loading

openshift-ci bot commented Feb 9, 2024

prb112 Feb 9, 2024

prb112 Feb 9, 2024

SNiemann15 Feb 9, 2024

prb112 Feb 9, 2024

prb112 Feb 9, 2024

SNiemann15 Feb 9, 2024

SNiemann15 Feb 9, 2024

prb112 Feb 9, 2024

alishaIBM commented Feb 13, 2024

holgwolf commented Feb 14, 2024

prb112 left a comment

SNiemann15 commented Feb 15, 2024

SNiemann15 commented Feb 15, 2024

skrthomas left a comment

skrthomas Feb 15, 2024

skrthomas Feb 15, 2024

SNiemann15 Feb 16, 2024

SNiemann15 commented Feb 16, 2024

SNiemann15 commented Feb 16, 2024

snarayan-redhat commented Feb 16, 2024

openshift-cherrypick-robot commented Feb 16, 2024


		Before you can add 64-bit ARM nodes to your bare metal cluster, you must upgrade your cluster to one that uses the multi-architecture payload. For more information on migrating to the multi-architecture payload, see xref:../../updating/updating_a_cluster/migrating-to-multi-payload.adoc#migrating-to-multi-payload[Migrating to a cluster with multi-architecture compute machines].
		* xref:../../installing/installing_bare_metal/installing-bare-metal.adoc#installing-bare-metal[Installing a user provisioned cluster on bare metal]. You can then add 64-bit ARM compute machines to your {product-title} cluster on bare metal.

	To create a cluster with multi-architecture compute machines on bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:
	To create a cluster with multi-architecture compute machines on either bare metal (`x86_64`), {ibm-power-name} (`ppc64le`), or {ibm-z-name} (`s390x`) you must have an existing single-architecture cluster on one of these platforms. Follow the installations procedures for your platform:

	To create an {ibm-power-name} (`ppc64le`) cluster with multi-architecture compute machines on `x86_64`, follow the instructions for
	To create an {ibm-power-name} (`ppc64le`) cluster with multiarchitecture compute machines on `x86_64`, follow the instructions for

[OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71418

[OSDOCS-7500] multi-architecture IBM Power and IBM Z control planes #71418

Conversation

SNiemann15 commented Feb 9, 2024 • edited Loading

ocpdocs-previewbot commented Feb 9, 2024 • edited Loading

openshift-ci bot commented Feb 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alishaIBM commented Feb 13, 2024

holgwolf commented Feb 14, 2024

prb112 left a comment

Choose a reason for hiding this comment

SNiemann15 commented Feb 15, 2024

SNiemann15 commented Feb 15, 2024

skrthomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SNiemann15 commented Feb 16, 2024

SNiemann15 commented Feb 16, 2024

snarayan-redhat commented Feb 16, 2024

openshift-cherrypick-robot commented Feb 16, 2024

SNiemann15 commented Feb 9, 2024 •

edited

Loading

ocpdocs-previewbot commented Feb 9, 2024 •

edited

Loading