Skip to content

OBSDOCS-280: Update internal log store refs #71711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

OBSDOCS-280: Update internal log store refs #71711

merged 1 commit into from
Feb 19, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Feb 15, 2024 •
edited
Loading

@abrennan89 abrennan89 added this to the Continuous Release milestone Feb 15, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-280

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 15, 2024 •
edited
Loading

🤖 Mon Feb 19 15:12:12 - Prow CI generated the docs preview: https://71711--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-280

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcantrill
jcantrill reviewed Feb 16, 2024
View reviewed changes
Copy link

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
anpingli
anpingli reviewed Feb 17, 2024
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-280

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 19, 2024
@skopacz1
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 19, 2024
skopacz1
skopacz1 reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one question, but otherwise looks good to me!

@skopacz1
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 19, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2024

New changes are detected. LGTM label has been removed.

1 similar comment
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit 0379b38 into openshift:main Feb 19, 2024
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.12

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #71815

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #71816

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #71817

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #71818

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2024
Merged
@abrennan89 abrennan89 deleted the OBSDOCS-280 branch July 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@anpingli anpingli anpingli left review comments

@skopacz1 skopacz1 skopacz1 left review comments

@kabirbhartiRH kabirbhartiRH Awaiting requested review from kabirbhartiRH

Assignees

@jcantrill jcantrill

@anpingli anpingli

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @skopacz1 @openshift-cherrypick-robot @jcantrill @anpingli