Clarified support for journald per BZ #7191

mburke5678 · 2018-01-16T18:04:22Z

https://bugzilla.redhat.com/show_bug.cgi?id=1526262

mburke5678 · 2018-01-16T18:37:29Z

I added the wording from the release notes to the Aggregating Container Logs topic (removing the existing wording from the NOTE).
I removed the Aggregated logging is only supported using the journald driver in Docker. wording from the Host Preparation page, as the section seems focused on json-file and log size, not journald.
Are there concerns with journald log size that we want to add somewhere?
How does a user changes between json-file and journald?

anpingli · 2018-01-24T08:44:15Z

install_config/aggregate_logging.adoc

+[IMPORTANT]
+====
+If Docker log-driver is set to journald, there is no log rate throttling with the `journald` driver. 
+As a result, there is always a risk for denial-of-service attacks from rogue containers.


I suggest add the bug https://bugzilla.redhat.com/show_bug.cgi?id=1526262 and ask customer to check the docker version when use json-file

@anpingli Added:
When using the json-file driver, ensure that your Docker version is Docker version docker-1.12.6-55.gitc4618fb.el7_4 now or greater.

Is this correct?

@anpingli PTAL ^^

The latest docker is docker-1.12.7. No such issue. I recall my suggestion.

anpingli · 2018-01-24T09:29:06Z

install_config/aggregate_logging.adoc

+
+To change between `json-file` and `journald` after installation:
+
+. Set the `log-driver` parameter to appropriate values in the *_/etc/origin/node/node-config.yaml_* file 


The docker Logging driver is json-file by default
To change the Logging driver, you can modify either /etc/sysconfig/docker or /etc/docker/daemon.json.
For example:
cat /etc/sysconfig/docker
OPTIONS=' --selinux-enabled --log-driver=json-file --log-opt max-size=1M --log-opt max-file=3 --signature-verification=False'

cat /etc/docker/daemon.json
{
"log-driver": "json-file",
"log-opts": {
"max-size": "1M",
"max-file": "1"
}
}

anpingli · 2018-01-24T09:31:30Z

install_config/aggregate_logging.adoc

+restart the Docker service.
+
+----
+dockerConfig:


I am not sure if we can change the log-driver in node-config.yml especially in docker daemon level.

anpingli · 2018-01-24T09:33:38Z

install_config/install/advanced_install.adoc

+Example usage: 
+----
+"--log-driver json-file --log-opt max-size=1M --log-opt max-file=3"
+"--log-driver journald --log-opt max-size=1M --log-opt max-file=3" 


The log options (--log-opt max-size=1M --log-opt max-file=3) are for json-file only.

@anpingli If the user wants to change these settings after install, could he use the /etc/docker/daemon.json?
Are these fields needed in the /etc/ansible/hosts?

Yes, They can change the values in /etc/docker/daemon.json directly.

change "--log-driver journald --log-opt max-size=1M --log-opt max-file=3" to "--log-driver journald ". The other part looks good.

anpingli · 2018-01-24T09:38:30Z

install_config/aggregate_logging.adoc

+By default, aggregated logging uses the `json-file` driver 
+xref:../install_config/install/advanced_install.adoc#configuring-host-variables[unless `journald` was specified during installation].
+
+Use the `docker info` command to determine which driver Docker is using:


fluentd determine the driver Docker by checking /etc/docker/daemon.json and /etc/sysconfig/docker.

mburke5678 · 2018-01-31T00:09:09Z

@anpingli PTAL

anpingli · 2018-02-01T07:25:55Z

install_config/install/advanced_install.adoc

+Example usage: 
+----
+"--log-driver json-file --log-opt max-size=1M --log-opt max-file=3"
+"--log-driver journald --log-opt max-size=1M --log-opt max-file=3" 


Yes, They can change the values in /etc/docker/daemon.json directly.

mburke5678 · 2018-02-01T16:28:53Z

@anpingli Do you know what OpenShift versions this issues applies to? How far back do we support json-file and journald?

mburke5678 · 2018-02-15T16:33:12Z

@anpingli Do you know what OpenShift versions this issues applies to? How far back do we support json-file and journald?

anpingli · 2018-02-22T01:15:35Z

@mburke5678, Openshift support both journald/json file driver always. In v3.4, the default driver is json-file if you deploy openshift using openshift-ansile. In v3.5-v3.7, For Bug526262, The default driver is changed to journald. In v3.9, we had changed backup to json driver.

mburke5678 · 2018-02-22T15:44:11Z

@anpingli The 3.7 release notes say that json-file is the default. But, you suggest that journald is the default. (I tested in a 3.5 Ravello system and I get journald).

mburke5678 · 2018-02-22T15:49:08Z

@openshift/team-documentation PTAL.
In 3.5 journald made the default:
https://docs.openshift.com/container-platform/3.5/release_notes/ocp_3_5_release_notes.html#ocp-3-5-rhba-2017-0903-bug-fixes
Changing the json-file in 3.9
#8071

mburke5678 · 2018-02-23T20:58:28Z

@openshift/team-documentation PTAL.

mburke5678 · 2018-02-23T21:03:46Z

Note to self: Follow up in 3.9; change default to json-file

ahardin-rh · 2018-02-23T21:35:04Z

install_config/aggregate_logging.adoc

+
+By default, aggregated logging uses the `journald` log driver 
+xref:../install_config/install/advanced_install.adoc#configuring-host-variables[unless `json-file` was specified during installation]. 
+You can change the log driver between `journald` and `json-file` as needed.


Is "You can change..." supposed to be on a new line?

ahardin-rh · 2018-02-23T21:35:13Z

install_config/aggregate_logging.adoc

+[IMPORTANT]
+====
+When using the `json-file` driver, ensure that your Docker version is Docker version *docker-1.12.6-55.gitc4618fb.el7_4 now*
+or greater.


s/greater/later

ahardin-rh · 2018-02-23T21:36:33Z

@mburke5678 Just a few nits from me. Otherwise, looks good! 🌟

mburke5678 · 2018-02-23T22:06:25Z

/cherrypick enterprise-3.6

openshift-cherrypick-robot · 2018-02-23T22:06:32Z

@mburke5678: new pull request created: #7922

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mburke5678 · 2018-02-23T22:06:56Z

/cherrypick enterprise-3.7

openshift-cherrypick-robot · 2018-02-23T22:07:03Z

@mburke5678: new pull request created: #7923

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mburke5678 · 2018-02-23T22:07:45Z

/cherrypick enterprise-3.9

openshift-cherrypick-robot · 2018-02-23T22:07:51Z

@mburke5678: new pull request created: #7924

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mburke5678 · 2018-06-20T15:40:23Z

Fixed release notes that was missed when working on this PR

See https://bugzilla.redhat.com/show_bug.cgi?id=1526262#c16

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2018

anpingli reviewed Jan 26, 2018

View reviewed changes

anpingli approved these changes Feb 1, 2018

View reviewed changes

mburke5678 force-pushed the BZ-1526262 branch from 5142110 to 5a8ed7c Compare February 1, 2018 16:20

mburke5678 added branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 labels Feb 1, 2018

mburke5678 removed branch/enterprise-3.5 branch/enterprise-3.6 labels Feb 19, 2018

mburke5678 added the branch/enterprise-3.6 label Feb 22, 2018

mburke5678 added this to the Next Release milestone Feb 22, 2018

mburke5678 removed the branch/enterprise-3.6 label Feb 22, 2018

mburke5678 force-pushed the BZ-1526262 branch from 38c52a4 to 9dcbc1b Compare February 22, 2018 15:33

mburke5678 added the branch/enterprise-3.6 label Feb 22, 2018

mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 22, 2018

mburke5678 force-pushed the BZ-1526262 branch from f5c476f to 0fb3037 Compare February 23, 2018 21:29

ahardin-rh reviewed Feb 23, 2018

View reviewed changes

clarified support for journald per BZ

0f7c261

mburke5678 force-pushed the BZ-1526262 branch from 0fb3037 to 0f7c261 Compare February 23, 2018 21:50

mburke5678 merged commit 618155f into openshift:master Feb 23, 2018

openshift-cherrypick-robot mentioned this pull request Feb 23, 2018

[enterprise-3.6] Clarified support for journald per BZ #7922

Merged

openshift-cherrypick-robot mentioned this pull request Feb 23, 2018

[enterprise-3.7] Clarified support for journald per BZ #7923

Merged

openshift-cherrypick-robot mentioned this pull request Feb 23, 2018

[enterprise-3.9] Clarified support for journald per BZ #7924

Merged

gaurav-nelson mentioned this pull request Feb 27, 2018

Recreated advanced_install.adoc from history #7953

Closed

This was referenced Mar 7, 2018

Removed reference to only journald #8049

Merged

Docker logging driver changes to json-file in 3.9 #8071

Merged

mburke5678 deleted the BZ-1526262 branch June 20, 2018 15:24

mburke5678 mentioned this pull request Jun 20, 2018

Changed default Docker driver in Release Notes per BZ #10282

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clarified support for journald per BZ #7191

Clarified support for journald per BZ #7191

mburke5678 commented Jan 16, 2018

mburke5678 commented Jan 16, 2018

anpingli Jan 24, 2018

mburke5678 Jan 29, 2018

mburke5678 Feb 5, 2018

anpingli Feb 22, 2018

anpingli Feb 22, 2018

anpingli Jan 24, 2018

anpingli Jan 24, 2018

anpingli Jan 24, 2018

mburke5678 Jan 29, 2018

anpingli Feb 1, 2018

anpingli Feb 1, 2018

anpingli Jan 24, 2018

mburke5678 commented Jan 31, 2018

anpingli Feb 1, 2018

mburke5678 commented Feb 1, 2018

mburke5678 commented Feb 15, 2018

anpingli commented Feb 22, 2018

mburke5678 commented Feb 22, 2018

mburke5678 commented Feb 22, 2018 •

edited

Loading

mburke5678 commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

ahardin-rh Feb 23, 2018

ahardin-rh Feb 23, 2018

ahardin-rh commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Jun 20, 2018


		To change between `json-file` and `journald` after installation:

		. Set the `log-driver` parameter to appropriate values in the _/etc/origin/node/node-config.yaml_ file

Clarified support for journald per BZ #7191

Clarified support for journald per BZ #7191

Conversation

mburke5678 commented Jan 16, 2018

mburke5678 commented Jan 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mburke5678 commented Jan 31, 2018

Choose a reason for hiding this comment

mburke5678 commented Feb 1, 2018

mburke5678 commented Feb 15, 2018

anpingli commented Feb 22, 2018

mburke5678 commented Feb 22, 2018

mburke5678 commented Feb 22, 2018 • edited Loading

mburke5678 commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahardin-rh commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Feb 23, 2018

openshift-cherrypick-robot commented Feb 23, 2018

mburke5678 commented Jun 20, 2018

mburke5678 commented Feb 22, 2018 •

edited

Loading