Skip to content

OCPBUGS-27426:Add admin groups info to NetObserv #72058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2024
Merged

OCPBUGS-27426:Add admin groups info to NetObserv #72058

merged 1 commit into from
Mar 22, 2024

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Feb 22, 2024 •
edited
Loading

Version(s):

4.12+
Issues:

There are two related bugs addressed in this PR:

Link to docs preview:

Loki docs: Custom admin group access (note that the asciidoc tags effectively keep all the Loki topics for Fine grained access to Loki logs and render a different callout 1 than for NetObserv)

NetObserv docs:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 22, 2024
@openshift-ci-robot
Copy link

@skrthomas: This pull request references Jira Issue OCPBUGS-27426, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2024 •
edited
Loading

🤖 Mon Feb 26 19:46:21 - Prow CI generated the docs preview: https://72058--ocpdocs-pr.netlify.app

@skrthomas skrthomas requested a review from libander February 22, 2024 18:49
libander
libander approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@libander libander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Looks great, the tag naming convention makes it really easy to follow.

@skrthomas skrthomas force-pushed the OCPBUGS-27426 branch 4 times, most recently from 1e1eab9 to 192dbab Compare February 22, 2024 20:48
@libander
Copy link
Contributor

I think the modules for loki can be [leveloffset =+1], but the preview looks fine as is. Looks great!

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2024
@skrthomas skrthomas force-pushed the OCPBUGS-27426 branch 4 times, most recently from 87c5909 to f776358 Compare February 26, 2024 19:22
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2024

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skrthomas skrthomas requested review from jotak and memodi February 26, 2024 20:48
@skrthomas
Copy link
Contributor Author

@dhgautam99 Can you PTAL at this PR?

@openshift-ci-robot
Copy link

@skrthomas: This pull request references Jira Issue OCPBUGS-27426, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):

4.12+
Issue:

https://issues.redhat.com/browse/OCPBUGS-27426 and https://issues.redhat.com/browse/OCPBUGS-29538
Link to docs preview:

Loki docs (note that the asciidoc tags effectively keep all the Loki topics): https://72058--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_storage/cluster-logging-loki
NetObserv docs: https://72058--ocpdocs-pr.netlify.app/openshift-enterprise/latest/network_observability/installing-operators#logging-creating-new-group-cluster-admin-user-role_network_observability
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

memodi
memodi reviewed Feb 27, 2024
View reviewed changes
Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skrthomas - could you add the the doc preview of these changes? the one attached on PR sends me to landing page.

@skrthomas
Copy link
Contributor Author

@memodi there are links to the previews for Logging and Network Observability in the initial comment box where I have the versions and links to the OCPBUGS tickets. The ocp previewbot preview comment isn't the one to check because it will put you on the landing page.

@bburt-rh bburt-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 22, 2024
@bburt-rh bburt-rh added this to the Continuous Release milestone Mar 22, 2024
bburt-rh
bburt-rh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Perfect use case for tags!

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 22, 2024
@skrthomas
Copy link
Contributor Author

TY @bburt-rh <3

@skrthomas skrthomas merged commit 48690d4 into openshift:main Mar 22, 2024
@openshift-ci-robot
Copy link

@skrthomas: Jira Issue OCPBUGS-27426 is in an unrecognized state (Release Pending) and will not be moved to the MODIFIED state.

In response to this:

Version(s):

4.12+
Issues:

There are two related bugs addressed in this PR:

Link to docs preview:

Loki docs: Custom admin group access (note that the asciidoc tags effectively keep all the Loki topics for Fine grained access to Loki logs and render a different callout 1 than for NetObserv)

NetObserv docs:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.15

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.14

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #73654

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #73655

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #73656

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 22, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #73658

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #73659

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@skrthomas skrthomas mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

@memodi memodi memodi approved these changes

@libander libander libander approved these changes

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@kalexand-rh kalexand-rh Awaiting requested review from kalexand-rh

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@skrthomas @openshift-ci-robot @ocpdocs-previewbot @libander @openshift-cherrypick-robot @jotak @bburt-rh @memodi @jpinsonneau