Skip to content

RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes #72104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes #72104

merged 1 commit into from
Jun 20, 2024

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Feb 26, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

…ffic manager for Argo Rollouts

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2024

Hi @Dhruv-Soni11. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 26, 2024 •
edited
Loading

🤖 Thu Jun 20 06:17:00 - Prow CI generated the docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 3 times, most recently from 87ab53a to 23c7306 Compare February 26, 2024 10:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11 Dhruv-Soni11 changed the title RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a tra… RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts Feb 26, 2024
@Dhruv-Soni11 Dhruv-Soni11 changed the title RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts WIP: RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts Feb 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Peer review: @Srivaralakshmi

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Srivaralakshmi
Srivaralakshmi reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Just skimmed through the PR and gave a few suggestions for you to consider. The PR needs a thorough self-review and good scrub.

After it is ready, please send it to @eromanova97 for internal peer review. @eromanova97, please assist Dhruv with a thorough internal peer review. Thanks!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 2 times, most recently from a8e2f2b to b76700b Compare February 27, 2024 08:34
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 2 times, most recently from 0657255 to a064a35 Compare February 27, 2024 11:53
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 3 times, most recently from 9d91b96 to ebade7a Compare March 1, 2024 15:41
@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 18, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 18, 2024
@skopacz1
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2024
skopacz1
skopacz1 reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but otherwise looks good to me, nicely done!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

/retest

3 similar comments
@Dhruv-Soni11
Copy link
Contributor Author

/retest

@Dhruv-Soni11
Copy link
Contributor Author

/retest

@Dhruv-Soni11
Copy link
Contributor Author

/retest

@Dhruv-Soni11
Copy link
Contributor Author

Left a few comments but otherwise looks good to me, nicely done!

Hey @skopacz1 - Thanks for providing the comments. I have fixed all of them. PTAL.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 20, 2024

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 20, 2024
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jun 20, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh merged commit 6f6152b into openshift:gitops-docs-main Jun 20, 2024
3 checks passed
@bscott-rh
Copy link
Contributor

/cherrypick gitops-docs-1.13

@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #77761

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgwest jgwest jgwest requested changes

@ishitasequeira ishitasequeira ishitasequeira left review comments

@varshab1210 varshab1210 varshab1210 left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@eromanova97 eromanova97 eromanova97 left review comments

@skopacz1 skopacz1 skopacz1 left review comments

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.