Skip to content

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP #72358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Feb 28, 2024

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:
ROSA:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:
ROSA:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 29, 2024

🤖 Wed Mar 27 12:04:15 - Prow CI generated the docs preview:
https://72358--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 29, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:
ROSA: https://72358--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_architecture/rosa_architecture_sub/rosa-architecture-models

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:
Architecture models: https://72358--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_architecture/rosa_architecture_sub/rosa-architecture-models
Creating ROSA with HCP clusters using the default options: https://72358--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-sts-creating-a-cluster-quickly

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2024
@jneczypor jneczypor force-pushed the OSDOCS-9589 branch 2 times, most recently from 18e9c82 to 5d28053 Compare March 7, 2024 20:32
Copy link

@bchandra-ocp bchandra-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Great work and I've left few comments.

@jneczypor jneczypor force-pushed the OSDOCS-9589 branch 3 times, most recently from 593efb6 to dc54f16 Compare March 19, 2024 15:30
@jneczypor
Copy link
Contributor Author

Hi @bchandra-ocp - Can you please take a look at this PR? Thanks!

@jneczypor
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 26, 2024
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Mar 26, 2024
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits. Please reach out over Slack if you have any questions.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 27, 2024

@jneczypor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@jneczypor: This pull request references OSDOCS-9589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-9589: Update Architecture Models Sub-Section to Show the Differences between Classic and HCP

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-9589

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@EricPonvelle EricPonvelle merged commit d2ca5e0 into openshift:main Mar 27, 2024
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #73823

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #73824

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants