Skip to content

Bug 1520176 Correct logging variable and install default status #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

bmcelvee
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1520176

@ewolinetz @jcantrill I changed this content according to the feedback from IRC yesterday. Is the openshift_hosted_logging_deploy=true variable still correct?

Thanks!

@bmcelvee bmcelvee added this to the Next Release milestone Jan 23, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2018
@ewolinetz
Copy link

@bmcelvee the variable should be openshift_logging_install_logging now, openshift_hosted_logging_deploy was deprecated.

@bmcelvee
Copy link
Contributor Author

@ewolinetz, right! Thanks, it's fixed.

@bmcelvee bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 24, 2018
@bmcelvee
Copy link
Contributor Author

@openshift/team-documentation PTAL 🌻

Starting with {product-title} 3.7, cluster logging is set to deploy
automatically by default during installation.
Cluster logging is not set to automatically deploy by default. Set the
following to enable cluster logging when using the advanced install:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/install/installation method

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 24, 2018
@ahardin-rh
Copy link
Contributor

@bmcelvee Just one minor comment from me 👍

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Jan 24, 2018

[rev_history]
|xref:../install_config/install/advanced_install.adoc#install-config-install-advanced-install[Advanced Installation]
|Corrected logging variable and updated default installation status in the xref:../install_config/install/advanced_install.adoc#advanced-install-cluster-logging[Configuring Cluster Logging] section.
%

@bmcelvee bmcelvee merged commit 9a9a6c2 into openshift:master Jan 24, 2018
bmcelvee added a commit to bmcelvee/openshift-docs that referenced this pull request Jan 24, 2018
bmcelvee added a commit to bmcelvee/openshift-docs that referenced this pull request Jan 24, 2018
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published 25/Jan/2018 Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants