Skip to content

OBSDOCS-890: Updates for http input receiver docs #73567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

OBSDOCS-890: Updates for http input receiver docs #73567

merged 1 commit into from
Mar 27, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Mar 21, 2024 •
edited
Loading

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#cluster-logging-collector-input-receivers

QE review:

  • QE has approved this change.

Additional information:
Follow up from syslog bug https://issues.redhat.com/browse/OBSDOCS-890 to also provide these updates for the 4.12+ HTTP docs

@abrennan89 abrennan89 added this to the Continuous Release milestone Mar 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Follow up from syslog bug https://issues.redhat.com/browse/OBSDOCS-890 to also provide these updates for the 4.12+ HTTP docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2024 •
edited
Loading

🤖 Wed Mar 27 15:50:13 - Prow CI generated the docs preview:
https://73567--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#log-collector-http-server_cluster-logging-collector

QE review:

  • QE has approved this change.

Additional information:
Follow up from syslog bug https://issues.redhat.com/browse/OBSDOCS-890 to also provide these updates for the 4.12+ HTTP docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 22, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#cluster-logging-collector-input-receivers

QE review:

  • QE has approved this change.

Additional information:
Follow up from syslog bug https://issues.redhat.com/browse/OBSDOCS-890 to also provide these updates for the 4.12+ HTTP docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcantrill
jcantrill reviewed Mar 22, 2024
View reviewed changes
Copy link

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@abrennan89 abrennan89 mentioned this pull request Mar 22, 2024
Merged
1 task
anpingli
anpingli reviewed Mar 22, 2024
View reviewed changes
anpingli
anpingli reviewed Mar 22, 2024
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@abrennan89 abrennan89 requested a review from anpingli March 25, 2024 16:52
@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 26, 2024
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 26, 2024
GroceryBoyJr
GroceryBoyJr reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one tiny nit, otherwise LGTM.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 27, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 27, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#cluster-logging-collector-input-receivers

QE review:

  • QE has approved this change.

Additional information:
Follow up from syslog bug https://issues.redhat.com/browse/OBSDOCS-890 to also provide these updates for the 4.12+ HTTP docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 merged commit 1c9b431 into openshift:main Mar 27, 2024
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.12

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@abrennan89: #73567 failed to apply on top of branch "enterprise-4.12":

Applying: OBSDOCS-890: Updates for http input receiver docs
Using index info to reconstruct a base tree...
M	logging/log_collection_forwarding/cluster-logging-collector.adoc
Falling back to patching base and 3-way merge...
Auto-merging logging/log_collection_forwarding/cluster-logging-collector.adoc
CONFLICT (content): Merge conflict in logging/log_collection_forwarding/cluster-logging-collector.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-890: Updates for http input receiver docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #73818

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 27, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #73819

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 27, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #73820

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 27, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #73821

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 mentioned this pull request Mar 27, 2024
Merged
@abrennan89 abrennan89 deleted the OBSDOCS-890-http branch July 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@anpingli anpingli Awaiting requested review from anpingli

Assignees

@jcantrill jcantrill

@anpingli anpingli

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @anpingli @GroceryBoyJr @openshift-cherrypick-robot @jcantrill