Skip to content

OBSDOCS-901: rename-accessing-monitoring-apis-heading #73593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Mar 21, 2024

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-901

Link to docs preview: https://73593--ocpdocs-pr.netlify.app/openshift-enterprise/latest/monitoring/accessing-third-party-monitoring-apis

QE review: not required because technical content is not changing

Additional information:
This PR changes the heading name from "Accessing third-party monitoring APIs" to "Accessing monitoring APIs by using the CLI" and updates some related content to remove a reference to "third-party" components.

It also updates some incorrect metadata in modules included in this assembly.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024

@bburt-rh: This pull request references OBSDOCS-901 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-901

Link to docs preview:

QE review:

  • N/A because technical content is not changing

Additional information:
This PR gives a new title to the assembly "Accessing third-party monitoring APIs" and updates related content and metadata in modules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2024
@bburt-rh bburt-rh changed the title OBSDOCS-901: rename-accessing-monitoring-apis-assembly OBSDOCS-901: rename-accessing-monitoring-apis-title Mar 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2024

🤖 Fri Mar 22 13:19:02 - Prow CI generated the docs preview:
https://73593--ocpdocs-pr.netlify.app

@bburt-rh bburt-rh force-pushed the OBSDOCS-901-rename-accessing-monitoring-apis-assembly branch from 129d1ee to 5828bb4 Compare March 22, 2024 13:12
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
Copy link

openshift-ci bot commented Mar 22, 2024

@bburt-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bburt-rh bburt-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 22, 2024
@openshift openshift deleted a comment from openshift-ci-robot Mar 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 22, 2024

@bburt-rh: This pull request references OBSDOCS-901 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-901

Link to docs preview: https://73593--ocpdocs-pr.netlify.app/openshift-enterprise/latest/monitoring/accessing-third-party-monitoring-apis

QE review: not required because technical content is not changing

Additional information:
This PR changes the heading name from "Accessing third-party monitoring APIs" to "Accessing monitoring APIs by using the CLI" and updates some related content to remove a reference to "third-party" components.

It also updates some incorrect metadata in modules included in this assembly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bburt-rh bburt-rh changed the title OBSDOCS-901: rename-accessing-monitoring-apis-title OBSDOCS-901: rename-accessing-monitoring-apis-heading Mar 22, 2024
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 22, 2024
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@skrthomas skrthomas removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 22, 2024
@skrthomas skrthomas added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 22, 2024
@bburt-rh bburt-rh merged commit 3cdf0f4 into openshift:main Mar 22, 2024
2 checks passed
@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.14

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.15

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@bburt-rh: #73593 failed to apply on top of branch "enterprise-4.12":

Applying: OBSDOCS-901-rename-accessing-monitoring-apis-assembly
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	monitoring/reviewing-monitoring-dashboards.adoc
Falling back to patching base and 3-way merge...
Auto-merging monitoring/reviewing-monitoring-dashboards.adoc
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-901-rename-accessing-monitoring-apis-assembly
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #73648

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #73649

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #73650

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #73651

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants