-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-1819: Rename controller-manager to controller #73714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Mar 26 15:31:53 - Prow CI generated the docs preview: |
@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -1,4 +1,4 @@ | |||
// Module included in the following assemblies: | |||
/ Module included in the following assemblies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this desirable?
cb3d16a
to
cf6d2da
Compare
/lgtm |
@StephenJamesSmith: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@StephenJamesSmith: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-label peer-review-needed |
/label merge-review-needed |
@StephenJamesSmith does this go into 4.16 too? |
@JoeAldinger Based on the Epic and these comments from @qbarrand (Let us put all the new content in 4.14+. We will likely release KMM 2.1 (April / May) for OCP 4.12+. At that point we will ask to align all 4.1{2,3,4} docs on whatever we have for 4.15.) I assume it will end up in 4.16. |
4.14+ I would think includes 4.16. The reason I'm asking is that it would be an edge case to put something in 4.14 and 4.15, but not 4.16. Not that, that isn't what this is. I just want to make sure we get this in the right branches. |
@JoeAldinger Along with this story, there are more Jiras coming that all deal with changes to KMM 2 that will be treated the same. Agreed - I'm assuming that "4.14+" includes changes for 4.16. I suppose I could add 4.16 as an (unreleased) version. |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
@JoeAldinger: new pull request created: #73827 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoeAldinger: new pull request created: #73828 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoeAldinger: new pull request created: #73829 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
D/S Docs: [MGMT-17316] Doc updates for v2.x
Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)
Version(s): KMM 2.1, openshift-4.15, openshift-4.14
Link to docs preview: https://73714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management
SME review: @qbarrand
QE review: @cdvultur