Skip to content

TELCODOCS-1819: Rename controller-manager to controller #73714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

StephenJamesSmith
Copy link
Contributor

@StephenJamesSmith StephenJamesSmith commented Mar 25, 2024

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1, openshift-4.15, openshift-4.14

Link to docs preview: https://73714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management

SME review: @qbarrand
QE review: @cdvultur

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1

Link to docs preview:

SME review: @qbarrand
QE review: @cdvultur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2024
@StephenJamesSmith StephenJamesSmith changed the title TELCODOCS-1819: First draft [WIP]TELCODOCS-1819: First draft Mar 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024

🤖 Tue Mar 26 15:31:53 - Prow CI generated the docs preview:
https://73714--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1, openshift-4.15, openshift-4.14

Link to docs preview:

SME review: @qbarrand
QE review: @cdvultur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1, openshift-4.15, openshift-4.14

Link to docs preview: https://73714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management

SME review: @qbarrand
QE review: @cdvultur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith
Copy link
Contributor Author

@qbarrand @cdvultur Please review to ensure that all instances of controller-manager have been changed to controller. Please add /lgtm comment if all is well. Thx!

Copy link

@cdvultur cdvultur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@@ -1,4 +1,4 @@
// Module included in the following assemblies:
/ Module included in the following assemblies:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this desirable?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@qbarrand
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@StephenJamesSmith StephenJamesSmith changed the title [WIP]TELCODOCS-1819: First draft TELCODOCS-1819 Mar 26, 2024
@openshift-ci-robot
Copy link

@StephenJamesSmith: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1, openshift-4.15, openshift-4.14

Link to docs preview: https://73714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management

SME review: @qbarrand
QE review: @cdvultur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@StephenJamesSmith StephenJamesSmith changed the title TELCODOCS-1819 TELCODOCS-1819: Rename controller-manager to controller Mar 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

D/S Docs: [MGMT-17316] Doc updates for v2.x

Jira: https://issues.redhat.com/browse/MGMT-17316 (Rename controller-manager to controller)

Version(s): KMM 2.1, openshift-4.15, openshift-4.14

Link to docs preview: https://73714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management

SME review: @qbarrand
QE review: @cdvultur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Mar 26, 2024

@StephenJamesSmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@StephenJamesSmith
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 26, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 26, 2024
@StephenJamesSmith
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 26, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 27, 2024
@JoeAldinger JoeAldinger self-assigned this Mar 27, 2024
@JoeAldinger
Copy link
Contributor

@StephenJamesSmith does this go into 4.16 too?

@StephenJamesSmith
Copy link
Contributor Author

StephenJamesSmith commented Mar 27, 2024

@JoeAldinger Based on the Epic and these comments from @qbarrand (Let us put all the new content in 4.14+. We will likely release KMM 2.1 (April / May) for OCP 4.12+. At that point we will ask to align all 4.1{2,3,4} docs on whatever we have for 4.15.) I assume it will end up in 4.16.

@JoeAldinger
Copy link
Contributor

issues.redhat.com/browse/MGMT-17316

4.14+ I would think includes 4.16. The reason I'm asking is that it would be an edge case to put something in 4.14 and 4.15, but not 4.16. Not that, that isn't what this is. I just want to make sure we get this in the right branches.

@StephenJamesSmith
Copy link
Contributor Author

StephenJamesSmith commented Mar 27, 2024

@JoeAldinger Along with this story, there are more Jiras coming that all deal with changes to KMM 2 that will be treated the same. Agreed - I'm assuming that "4.14+" includes changes for 4.16. I suppose I could add 4.16 as an (unreleased) version.

@JoeAldinger JoeAldinger merged commit 8381361 into openshift:main Mar 27, 2024
@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.16

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #73827

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #73828

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #73829

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants