Changed securtityContext to securityContext #7374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
branch/enterprise-3.1
branch/enterprise-3.2
branch/enterprise-3.3
branch/enterprise-3.4
branch/enterprise-3.5
branch/enterprise-3.6
branch/enterprise-3.7
branch/enterprise-3.9
peer-review-needed
ghost
self-assigned this
openshift-ci-robot
added
the
size/XS
ghost
mentioned this pull request
|
LGTM :) |
|
@openshift/team-documentation PTAL. No rev history needed. |
|
@tmorriso-rh LGTM |
|
Hey @tmorriso-rh , first time contributor here (if you can call a typo commit a contribution!), just curious why you created your own branch again rather than merging from mine? It is because I didn't apply the right labels to the PR or something or do you prefer not to merge from people outside the project or something? Not fussed, just curious. Thanks! |
|
Hi @jamesread This was actually a mistake on my part. I should have fetched your PR, which would have allowed me to view and approve your contribution, and then merge the PR. So, no, you did things correctly. :-) Sorry for the confusion. |
ghost
added
peer-review-done
ghost
merged commit
This was referenced Feb 2, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamesread Please review. This is a follow-up to #7351.