-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
managing_networking: Document routes/custom-host #7398
managing_networking: Document routes/custom-host #7398
Conversation
@bfallonf - PTAL. |
admin_guide/managing_networking.adoc
Outdated
|
||
This is relevant to {product-title} installations that depend upon Kubernetes | ||
behavior, including allowing the host names in ingress objects be edited. | ||
objects is enabled by default. This means that regular users can set the host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/regular users/application developers?
Is that what you mean by users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled a bit with the terminology. I mean OpenShift users who do not have the cluster-admin role, for which "regular users" seems like a reasonable term. In contrast, the term "application developers" is less obviously a counterpart to "cluster administrator" and is not evocative of authorization and security roles. However, I would like to use the preferred term, whatever it may be.
For what it's worth, git grep
on the master branch finds 9 occurrences of "regular users" and 7 occurrences of "application developers". It also found 5 occurrences of "non-administrator users", but that's ambiguous (non-cluster administrator, non-project administrator, or other?).
So, "regular users", "application developers", or is there another, more suitable term?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Miciah Hmm I see. Would it be better to just say "users without the admin role"? "Regular users" does sound a little vague. Not sure if there's the perfect title for the role you're describing. Let me know what you think.
There's another instance on line 120 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed both occurrences of "regular users" to "users without the cluster-admin role". Does it read all right?
Would it be worthwhile to establish conventions for how to refer to users with or without a particular role, and document said conventions in contributing_to_docs/doc_guidelines.adoc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Miciah LGTM. As for the guidlines, I'll send an email out. It may be that there's an edge case here where you're wanting to refer to users that aren't admins (because otherwise they'd have the admin role), but who also aren't developers, so I'll see what the other writers think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, they may or may not be developers. RBAC and configurable security policies make devising clear and concise terminology a little tricky. An organization may choose to allow all application developers to edit route hosts, or allow project administrators to do so, or define some new kind of users that have fewer (or different) privileges than the cluster administrator has but more (or different) privileges than application developers have.
admin_guide/managing_networking.adoc
Outdated
afterwards. However, you can relax this restriction on routes and ingress | ||
objects for some or all users. | ||
|
||
[CAUTION] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/CAUTION/WARNING
I don't think we use caution anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I used "CAUTION" because I saw it further down in managing_networking.adoc
, but "WARNING" does seem to be much more common in other files. Fixed.
@Miciah Thanks for this. I think it sums up the process better. If you don't mind, there's a couple docs things to clear up, then I'll merge. Thanks! |
a26c7c7
to
3ba7baf
Compare
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340
3ba7baf
to
4e7bc64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Miciah
[rev_history] |
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340 (cherry picked from commit 4e7bc64) xref:openshift#7398
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340 (cherry picked from commit 4e7bc64) xref:openshift#7398
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340 (cherry picked from commit 4e7bc64) xref:openshift#7398
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340 (cherry picked from commit 4e7bc64) xref:openshift#7398
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses. Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it. Explicitly state that the cluster administrator can edit the host name on an existing route. Document how to disable host name collision prevention for routes. Add a "WARNING" marker to the text that explains about host name hijacking. This commit fixes bug 1536340. https://bugzilla.redhat.com/show_bug.cgi?id=1536340 (cherry picked from commit 4e7bc64) xref:openshift#7398
@bfallonf, sorry to have to bring up another issue, but while testing on 3.6, I discovered that For 3.6 and 3.7, we need to replace the following:
with the following:
Shall I open a PR against one or more of the 3.6 or 3.7 branches? I'm not familiar with whatever tooling you use to propagate changes to the various branches. |
Hi @Miciah . No worries. I can update the 3.6 and 3.7 branches with the above. Thanks for letting me know! |
Change the heading "Disabling Host Name Collision Prevention For Ingress Objects" read "Routes and Ingress Objects" because the section discusses both routes and ingresses.
Reorder the text to first state what host name collision prevention is, then its purpose, and then how to disable it.
Explicitly state that the cluster administrator can edit the host name on an existing route.
Document how to disable host name collision prevention for routes.
Add a "WARNING" marker to the text that explains about host name hijacking.
This commit fixes bug 1536340.
https://bugzilla.redhat.com/show_bug.cgi?id=1536340