Skip to content

[OSDOCS-10120]: Update Roles for the osd-ccs-admin service account within OSD docs #74062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mletalie
Copy link
Contributor

@mletalie mletalie commented Apr 2, 2024

Version(s):

4.15+
Issue:

https://issues.redhat.com/browse/OSDOCS-10120
Link to docs preview:

https://74062--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_planning/gcp-ccs#gcp-policy-instances_gcp-ccs
QE review:

  • QE has approved this change.

Additional information:

Reviewers: The scope of this ticket mainly focuses on making sure the lists shown in the attached image match what is presented in tables #1 and #2 here: https://docs.openshift.com/dedicated/osd_planning/gcp-ccs.html#ccs-gcp-customer-procedure_gcp-ccs

image

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2024
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Apr 2, 2024

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mletalie mletalie changed the title Osdocs 10120 [OSDOCS-10120]: Update Roles for the osd-ccs-admin service account within OSD docs Apr 2, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Apr 4, 2024

Hello @lento-sun,
Could I please get a QE review for this PR? Per the PR description, I just had confirm and then copy some duplicate info to another section in the topic. The roles were already established and approved here: #72303. There were two additional locations within the docs that should have been updated with that info but were missed. Thanks!

@tsze-redhat
Copy link

Sorry for forgetting to let you know, Mark, @valeriiashapoval will be looking at this today.

@valeriiashapoval
Copy link

@mletalie Just took another look, the change looks good to me! Thanks.

@mletalie
Copy link
Contributor Author

mletalie commented Apr 9, 2024

@mletalie Just took another look, the change looks good to me! Thanks.

Thanks @valeriiashapoval!

@aldiazRH
Copy link
Contributor

aldiazRH commented Apr 9, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 9, 2024
@aldiazRH
Copy link
Contributor

aldiazRH commented Apr 9, 2024

LGTM!

@aldiazRH
Copy link
Contributor

aldiazRH commented Apr 9, 2024

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2024
@EricPonvelle
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@EricPonvelle EricPonvelle merged commit 43cbb70 into openshift:main Apr 9, 2024
2 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #74414

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #74415

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants