Skip to content

Issue 6022: Fixed broken links to CNS for OCP content #7442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from Feb 13, 2018
Merged

Issue 6022: Fixed broken links to CNS for OCP content #7442

1 commit merged into from Feb 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2018

@Cameronwyatt This is a Follow-up to #6022. I fixed the broken links to the CNS content. Please review. Thanks!

@ghost ghost added branch/enterprise-3.6 peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 31, 2018
@ghost ghost added this to the Next Release milestone Jan 31, 2018
@ghost ghost self-assigned this Jan 31, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2018
@ghost
Copy link
Author

ghost commented Feb 1, 2018

@openshift/team-documentation PTAL. No rev history needed.

@liangxia
Copy link
Member

liangxia commented Feb 6, 2018

LGTM

1 similar comment
@jhou1
Copy link
Member

jhou1 commented Feb 6, 2018

LGTM

@mburke5678
Copy link
Contributor

@tmorriso-rh I assume this link is appropriate for all versions? The article subtitle suggests is it for 3.6? Otherwise LGTM

@ghost
Copy link
Author

ghost commented Feb 6, 2018

@mburke5678 Thanks, the broken link points to GlusterFS 3.1 docs, but I guess the version of GlusterFS used would depend on the version of OCP used, correct?

Should I change the link to the GlusterFS landing page? https://access.redhat.com/documentation/en-us/red_hat_gluster_storage/

Customer would have to select their version of GlusterFS to get the right doc.

@mburke5678
Copy link
Contributor

@vikram @aheslin Any thoughts on what @tmorriso-rh can do regarding the links to the Gluster storage docs? Hard coded links in each staging branch to the appropriate Gluster version? Link to the Gluster top page?
An Atom search shows 9 links to https://access.redhat.com/documentation/en-us/red_hat_gluster_storage/ in 4 files.

@ghost
Copy link
Author

ghost commented Feb 12, 2018

@aheslin @vikram-redhat Bump. Any thoughts on this? Thanks.

@vikram-redhat
Copy link
Contributor

@tmorriso-rh sadly in this case, we will need to update the links each time rather than point the users to a generic landing page.

As @mburke5678 has pointed out, there are 9 total links that need updating, so please do a search across the docs to find those 9 links and update them to the newer links. I suspect, this will be from 3.6 onwards.

@vikram-redhat
Copy link
Contributor

I have removed the labels for 3.2 to 3.5, as the new links are from 3.6 onwards as pointed out in the original issue.

@ghost ghost merged commit 1626634 into openshift:master Feb 13, 2018
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.6-stage

@openshift-cherrypick-robot

@tmorriso-rh: new pull request created: #7772

In response to this:

/cherrypick enterprise-3.6-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.7-stage

@openshift-cherrypick-robot

@tmorriso-rh: new pull request created: #7773

In response to this:

/cherrypick enterprise-3.7-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.9-stage

@openshift-cherrypick-robot

@tmorriso-rh: new pull request created: #7774

In response to this:

/cherrypick enterprise-3.9-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost deleted the Issue-6022-broken-links-for-CNS branch February 13, 2018 17:14
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published - 02/16/2018 Feb 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants