Skip to content

fix nesting of pipeline and openshift.withCluster in delcarative pipe… #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

gabemontero
Copy link
Contributor

…line example

@openshift/sig-developer-experience @bmcelvee ptal

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2018
@bmcelvee
Copy link
Contributor

bmcelvee commented Feb 2, 2018

LGTM! 🌻 To which versions does this fix apply?

@bparees
Copy link
Contributor

bparees commented Feb 2, 2018

@bmcelvee applies to all
/lgtm

@bmcelvee
Copy link
Contributor

bmcelvee commented Feb 2, 2018

Minor change. No revision history necessary.

@bmcelvee bmcelvee merged commit 26d5476 into openshift:master Feb 2, 2018
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Feb 2, 2018
… delcarative pipeline example

(cherry picked from commit a20f4d8) xref:openshift#7503
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Feb 2, 2018
… delcarative pipeline example

(cherry picked from commit a20f4d8) xref:openshift#7503
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Feb 2, 2018
…carative pipeline example

(cherry picked from commit a20f4d8) xref:openshift#7503
bmcelvee pushed a commit to bmcelvee/openshift-docs that referenced this pull request Feb 2, 2018
…carative pipeline example

(cherry picked from commit a20f4d8) xref:openshift#7503
@gabemontero gabemontero deleted the fix-pipeline-ex branch February 2, 2018 17:26
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published - 02/07/2018 Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.7 branch/enterprise-3.9 branch/online lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants