Skip to content

[OCPBUGS36313] Align IBM Z parm files #78298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

[OCPBUGS36313] Align IBM Z parm files #78298

merged 1 commit into from
Aug 14, 2024

Conversation

SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented Jul 1, 2024 •
edited
Loading

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/OCPBUGS-36313

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
https://docs.google.com/document/d/1Vfw2PHpyWFk61xL19hbuN1b1Pc-HCTHPKRCJddprYLE/edit#heading=h.uwdou3t3oz3l

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 1, 2024 •
edited
Loading

🤖 Mon Aug 12 15:07:44 - Prow CI generated the docs preview:

https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-ibm-z.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-ibm-z-kvm.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-ibm-z-lpar.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-restricted-networks-ibm-z.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-restricted-networks-ibm-z-kvm.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/installing-restricted-networks-ibm-z-lpar.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_sno/install-sno-installing-sno.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-ibm-z.html
https://78298--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-ibm-z-lpar.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2024
smolin-de
smolin-de reviewed Jul 16, 2024
View reviewed changes
Copy link

@smolin-de smolin-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my initial findings.
I need to check some parameters, therefore I do not approve now this PR.
Additional changes may be required.

smolin-de
smolin-de reviewed Jul 17, 2024
View reviewed changes
smolin-de

This comment was marked as outdated.

Sign in to view

smolin-de
smolin-de reviewed Aug 2, 2024
View reviewed changes
smolin-de
smolin-de suggested changes Aug 6, 2024
View reviewed changes
smolin-de
smolin-de suggested changes Aug 8, 2024
View reviewed changes
Copy link

@smolin-de smolin-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my latest comments.

@SNiemann15 SNiemann15 force-pushed the ibmz_parm_files branch 2 times, most recently from 56392b7 to 6a7017b Compare August 8, 2024 12:53
smolin-de
smolin-de reviewed Aug 8, 2024
View reviewed changes
smolin-de
smolin-de suggested changes Aug 9, 2024
View reviewed changes
@SNiemann15 SNiemann15 force-pushed the ibmz_parm_files branch 2 times, most recently from 1326a98 to a553644 Compare August 9, 2024 14:09
smolin-de
smolin-de suggested changes Aug 12, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 12, 2024

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SNiemann15 SNiemann15 changed the title [WIP] Align IBM Z parm files [OCPBUGS36313] Align IBM Z parm files Aug 13, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@holgwolf
Copy link

LGTM

@SNiemann15
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 13, 2024
@maxwelldb maxwelldb added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 14, 2024
@maxwelldb maxwelldb self-requested a review August 14, 2024 13:39
@maxwelldb maxwelldb added this to the Continuous Release milestone Aug 14, 2024
maxwelldb
maxwelldb approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 14, 2024
@SNiemann15
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 14, 2024
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 14, 2024
@ShaunaDiaz ShaunaDiaz merged commit be70b97 into openshift:main Aug 14, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 14, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #80508

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 14, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #80509

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SNiemann15 SNiemann15 deleted the ibmz_parm_files branch August 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

@smolin-de smolin-de smolin-de approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@SNiemann15 @ocpdocs-previewbot @holgwolf @ShaunaDiaz @openshift-cherrypick-robot @maxwelldb @smolin-de