OSDOCS#39419: Fixing procedure for creating live migration policies #78982

jherrman · 2024-07-17T08:28:11Z

Version(s):
4.15 and later

Issue:
https://issues.redhat.com/browse/CNV-39419

Link to docs preview:
https://78982--ocpdocs-pr.netlify.app/openshift-dedicated/latest/virt/live_migration/virt-configuring-live-migration.html
https://78982--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/live_migration/virt-configuring-live-migration.html
https://78982--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/live_migration/virt-configuring-live-migration.html

QE review:

QE has approved this change.

ocpdocs-previewbot · 2024-07-17T08:36:40Z

🤖 Wed Jul 31 14:06:03 - Prow CI generated the docs preview:

https://78982--ocpdocs-pr.netlify.app/openshift-dedicated/latest/virt/live_migration/virt-configuring-live-migration.html
https://78982--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/live_migration/virt-configuring-live-migration.html
https://78982--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/live_migration/virt-configuring-live-migration.html

dshchedr · 2024-07-30T18:54:41Z

/lgtm

jherrman · 2024-07-31T10:47:46Z

/label peer-review-needed

dfitzmau · 2024-07-31T11:01:22Z

/remove-label peer-review-needed

/label peer-review-in-progress

dfitzmau

Hi @jherrman . Please squash the commits. I see 5 commits lists on the Commits tab.

/remove-label peer-review-in-progress

/label peer-review-done

dfitzmau · 2024-07-31T11:03:28Z

modules/virt-configuring-a-live-migration-policy.adoc

@@ -6,7 +6,7 @@
 [id="virt-configuring-a-live-migration-policy_{context}"]
 = Creating a live migration policy by using the command line

-You can create a live migration policy by using the command line. A live migration policy is applied to selected virtual machines (VMs) by using any combination of labels:
+You can create a live migration policy by using the command line. KubeVirt applies live migration policy to selected virtual machines (VMs) by using any combination of labels:


Suggested change

You can create a live migration policy by using the command line. KubeVirt applies live migration policy to selected virtual machines (VMs) by using any combination of labels:

You can create a live migration policy by using the command line. KubeVirt applies the live migration policy to selected virtual machines (VMs) by using any combination of labels:

Good catch, will fix!

dfitzmau · 2024-07-31T11:05:57Z

modules/virt-configuring-a-live-migration-policy.adoc

+      labels:
+        kubevirt.io/domain: <vm-name>
+        kubevirt.io/size: large
+        kubevirt.io/environment: production


This might not be a complete YAML example, so consider ending the YAML with:

...

This syntax aligns with the following guideline:

https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#yaml-formatting

You're right, it's not complete, will indicate as much in the codeblock

dfitzmau · 2024-07-31T11:06:46Z

modules/virt-configuring-a-live-migration-policy.adoc

+  template:
+    metadata:
+      labels:
+        kubevirt.io/domain: <vm-name>


Suggested change

kubevirt.io/domain: <vm-name>

kubevirt.io/domain: <vm_name>

In two locations.

Forgot about https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#command-syntax-for-replaceable-values , thank you for the reminder!

dfitzmau · 2024-07-31T11:08:17Z

modules/virt-configuring-a-live-migration-policy.adoc

@@ -36,8 +68,7 @@ spec:
      hpc-workloads: "True"
      xyz-workloads-type: ""
    virtualMachineInstanceSelector: <2>
-      workload-type: "db"
-      operating-system: ""
+      "kubevirt.io/environment": "production"


Parentheses required here? I do not see them used in the other example.

AFAIK it should work either way, but you're right that for consistency, it'd be better if they weren't there.

jherrman · 2024-07-31T13:40:11Z

Hi @jherrman . Please squash the commits. I see 5 commits lists on the Commits tab.

Thanks for the quick review Darragh! I was planning to squash the commits before submitting for merge review (since it seems rather counter-productive at any point before that).

openshift-ci · 2024-07-31T14:00:34Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2024-07-31T14:08:48Z

@jherrman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jherrman · 2024-08-01T09:53:14Z

/label merge-review-needed

kcarmichael08 · 2024-08-01T14:54:31Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-08-01T14:55:21Z

@kcarmichael08: new pull request created: #79854

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kcarmichael08 · 2024-08-01T14:56:58Z

/cherrypick enterprise-4.16

kcarmichael08 · 2024-08-01T14:57:10Z

/cherrypick enterprise-4.17

openshift-cherrypick-robot · 2024-08-01T14:57:46Z

@kcarmichael08: new pull request created: #79856

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-01T14:57:58Z

@kcarmichael08: new pull request created: #79857

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2024

openshift-ci bot assigned dshchedr Jul 30, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 31, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 31, 2024

dfitzmau reviewed Jul 31, 2024

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 31, 2024

CNV-39419: Added new steps for live migration policies

7316215

jherrman force-pushed the CNV-39419 branch from 37e52e3 to 7316215 Compare July 31, 2024 14:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 1, 2024

kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 1, 2024

kcarmichael08 added this to the Continuous Release milestone Aug 1, 2024

kcarmichael08 merged commit 3e6ac62 into openshift:main Aug 1, 2024
2 checks passed

kcarmichael08 added the CNV Label for all CNV PRs label Aug 1, 2024

openshift-cherrypick-robot mentioned this pull request Aug 1, 2024

[enterprise-4.15] OSDOCS#39419: Fixing procedure for creating live migration policies #79854

Merged

openshift-cherrypick-robot mentioned this pull request Aug 1, 2024

[enterprise-4.16] OSDOCS#39419: Fixing procedure for creating live migration policies #79856

Merged

openshift-cherrypick-robot mentioned this pull request Aug 1, 2024

[enterprise-4.17] OSDOCS#39419: Fixing procedure for creating live migration policies #79857

Merged

kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 1, 2024

	You can create a live migration policy by using the command line. KubeVirt applies live migration policy to selected virtual machines (VMs) by using any combination of labels:
	You can create a live migration policy by using the command line. KubeVirt applies the live migration policy to selected virtual machines (VMs) by using any combination of labels:

OSDOCS#39419: Fixing procedure for creating live migration policies #78982

OSDOCS#39419: Fixing procedure for creating live migration policies #78982

Uh oh!

Conversation

jherrman commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dshchedr commented Jul 30, 2024

Uh oh!

jherrman commented Jul 31, 2024

Uh oh!

dfitzmau commented Jul 31, 2024

Uh oh!

dfitzmau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

...

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jherrman commented Jul 31, 2024

Uh oh!

openshift-ci bot commented Jul 31, 2024

Uh oh!

openshift-ci bot commented Jul 31, 2024

Uh oh!

jherrman commented Aug 1, 2024

Uh oh!

Uh oh!

kcarmichael08 commented Aug 1, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 1, 2024

Uh oh!

kcarmichael08 commented Aug 1, 2024

Uh oh!

kcarmichael08 commented Aug 1, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 1, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 1, 2024

Uh oh!

Uh oh!

jherrman commented Jul 17, 2024 •

edited

Loading

ocpdocs-previewbot commented Jul 17, 2024 •

edited

Loading