OCPBUGS-36696: Add details about how to remove OADP Operator after IBU #79042

amolnar-rh · 2024-07-18T09:59:52Z

Version(s): 4.16, 4.17

Issue: https://issues.redhat.com/browse/OCPBUGS-36696

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2024-07-18T09:59:57Z

@amolnar-rh: This pull request references Jira Issue OCPBUGS-36696, which is invalid:

expected the bug to target the "4.17.0" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.16, 4.17

Issue: issues.redhat.com/browse/OCPBUGS-36696

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-07-18T10:11:59Z

🤖 Wed Aug 14 09:38:28 - Prow CI generated the docs preview:

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-image-based-upgrade-base.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-generate-seed.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-install-operators.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-prep-resources.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/ztp-image-based-upgrade-prep-resources.html
https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/ztp-image-based-upgrade.html

modules/ztp-image-based-upgrade-upgrade.adoc

modules/ztp-image-based-upgrade-installing-oadp.adoc

modules/ztp-image-based-upgrade-upgrade.adoc

Missxiaoguo · 2024-07-19T16:52:14Z

/lgtm

amolnar-rh · 2024-07-31T08:59:21Z

/label peer-review-needed

dfitzmau · 2024-07-31T10:30:35Z

/remove-label peer-review-needed

/label peer-review-in-progress

dfitzmau

Hi @amolnar-rh . Nice work on this PR. Please squash the commits as I see 4 commits on this PR.

/remove-label peer-review-in-progress

/label peer-review-done

edge_computing/image_based_upgrade/ztp-image-based-upgrade.adoc

modules/ztp-image-based-upgrade-installing-lca.adoc

modules/ztp-image-based-upgrade-upgrade.adoc

openshift-ci · 2024-08-01T09:39:15Z

New changes are detected. LGTM label has been removed.

..._based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-prep-resources.adoc

josclark42 · 2024-08-12T16:11:55Z

/lgtm from QE

openshift-ci-robot · 2024-08-13T07:24:44Z

@amolnar-rh: This pull request references Jira Issue OCPBUGS-36696, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.16, 4.17

Issue: https://issues.redhat.com/browse/OCPBUGS-36696

Link to docs preview:

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-image-based-upgrade-base.html

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-install-operators.html

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/ztp-image-based-upgrade.html

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

amolnar-rh · 2024-08-13T07:24:52Z

/label peer-review-needed

bhardesty · 2024-08-13T15:14:48Z

/label peer-review-in-progress
/remove-label peer-review-needed

bhardesty

This looks great - I just had a couple very minor comments.

bhardesty · 2024-08-13T15:42:04Z

modules/ztp-image-based-upgrade-installing-oadp.adoc


 .Procedure

-. Create the following CRs in the `openshift-adp` namespace for both the seed and target clusters, then push the CRs to the `source-crs/custom-crs` directory:
+. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:


Suggested change

. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:

. Extract the following CRs from the `ztp-site-generate` container image and push them to the `source-cr` directory:

bhardesty · 2024-08-13T15:42:33Z

modules/ztp-image-based-upgrade-installing-oadp.adoc

      policyName: "subscriptions-policy"
 [...]
 ----

 . Create the `DataProtectionApplication` CR and the S3 secret only for the target cluster:

-.. Create the following CRs in your `source-crs/custom-crs` directory:
+.. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:


Suggested change

.. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:

.. Extract the following CRs from the `ztp-site-generate` container image and push them to the `source-cr` directory:

bhardesty · 2024-08-13T15:49:49Z

modules/ztp-image-based-upgrade-upgrade.adoc

+.. Change the `complianceType` to `mustnothave` for the {oadp-short} Operator namespace, Operator group, and subscription in the `common-ranGen.yaml` file.
+
+[source,yaml]


Is common-ranGen.yaml an OpenShift API object? If so, this and the following yaml examples should include the required fields (https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#required-fields).

It is and it's a file that is provided in the ztp-site-generate container by default so I'd think that the context is clear. However, we don't want to include the full content of the file, only the relevant bits, so I'm putting [...] at the beginning and end

bhardesty · 2024-08-13T15:50:29Z

modules/ztp-image-based-upgrade-upgrade.adoc

+.. Merge the changes with your custom site repository and wait for the ArgoCD application to synchronize the change to the hub cluster. The status of the `common-subscriptions-policy` and the `example-cnf-config-policy` policies change to `Non-Compliant`.
+
+.. Apply the change to your target clusters by using the {cgu-operator-full}. For more information about rolling out configuration changes, see the "Update policies on managed clusters".


Suggested change

.. Apply the change to your target clusters by using the {cgu-operator-full}. For more information about rolling out configuration changes, see the "Update policies on managed clusters".

.. Apply the change to your target clusters by using the {cgu-operator-full}. For more information about rolling out configuration changes, see "Update policies on managed clusters".

bhardesty · 2024-08-13T15:54:14Z

/label peer-review-done
/remove-label peer-review-in-progress

openshift-ci · 2024-08-14T09:40:06Z

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

amolnar-rh · 2024-08-14T09:53:16Z

/label merge-review-needed

openshift-ci-robot · 2024-08-14T17:27:30Z

@amolnar-rh: Jira Issue OCPBUGS-36696 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.16, 4.17

Issue: https://issues.redhat.com/browse/OCPBUGS-36696

Link to docs preview:

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-image-based-upgrade-base.html

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-install-operators.html

https://79042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/ztp-image-based-upgrade.html

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jab-rh · 2024-08-14T17:27:34Z

/cherry-pick enterprise-4.17

jab-rh · 2024-08-14T17:27:41Z

/cherry-pick enterprise-4.16

openshift-cherrypick-robot · 2024-08-14T17:28:22Z

@jab-rh: new pull request created: #80490

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-14T17:28:27Z

@jab-rh: new pull request created: #80491

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 18, 2024

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2024

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024

Missxiaoguo reviewed Jul 19, 2024

View reviewed changes

modules/ztp-image-based-upgrade-upgrade.adoc Outdated Show resolved Hide resolved

modules/ztp-image-based-upgrade-installing-oadp.adoc Outdated Show resolved Hide resolved

amolnar-rh force-pushed the OCPBUGS-36696 branch from 2eaba2c to 4894ad8 Compare July 19, 2024 13:10

Missxiaoguo reviewed Jul 19, 2024

View reviewed changes

modules/ztp-image-based-upgrade-upgrade.adoc Outdated Show resolved Hide resolved

amolnar-rh force-pushed the OCPBUGS-36696 branch 3 times, most recently from 00bb195 to a23a25e Compare July 19, 2024 16:00

openshift-ci bot assigned Missxiaoguo Jul 19, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 31, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 31, 2024

dfitzmau approved these changes Jul 31, 2024

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. labels Jul 31, 2024

ocpdocs-vale-bot reviewed Aug 1, 2024

View reviewed changes

..._based_upgrade/preparing_for_image_based_upgrade/cnf-image-based-upgrade-prep-resources.adoc Outdated Show resolved Hide resolved

amolnar-rh force-pushed the OCPBUGS-36696 branch from aa34295 to c98846f Compare August 1, 2024 10:03

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024

amolnar-rh force-pushed the OCPBUGS-36696 branch from c98846f to 809ad32 Compare August 7, 2024 10:16

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 13, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 13, 2024

bhardesty reviewed Aug 13, 2024

View reviewed changes

openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 13, 2024

OCPBUGS-36696: Add details about how to remove OADP Operator after IBU

61b9e72

amolnar-rh force-pushed the OCPBUGS-36696 branch from 809ad32 to 61b9e72 Compare August 14, 2024 09:31

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 14, 2024

jab-rh added branch/enterprise-4.16 branch/enterprise-4.17 labels Aug 14, 2024

jab-rh added this to the Continuous Release milestone Aug 14, 2024

jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 14, 2024

jab-rh merged commit a655523 into openshift:main Aug 14, 2024
2 checks passed

openshift-cherrypick-robot mentioned this pull request Aug 14, 2024

[enterprise-4.17] : Add details about how to remove OADP Operator after IBU #80490

Merged

openshift-cherrypick-robot mentioned this pull request Aug 14, 2024

[enterprise-4.16] : Add details about how to remove OADP Operator after IBU #80491

Merged

jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 14, 2024

	. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:
	. Extract the following CRs from the `ztp-site-generate` container image and push them to the `source-cr` directory:

	.. Extract the following CRs from the `ztp-site-generate` container image and push them to `source-cr` directory:
	.. Extract the following CRs from the `ztp-site-generate` container image and push them to the `source-cr` directory:

		.. Merge the changes with your custom site repository and wait for the ArgoCD application to synchronize the change to the hub cluster. The status of the `common-subscriptions-policy` and the `example-cnf-config-policy` policies change to `Non-Compliant`.

		.. Apply the change to your target clusters by using the {cgu-operator-full}. For more information about rolling out configuration changes, see the "Update policies on managed clusters".

OCPBUGS-36696: Add details about how to remove OADP Operator after IBU #79042

OCPBUGS-36696: Add details about how to remove OADP Operator after IBU #79042

Uh oh!

Conversation

amolnar-rh commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 18, 2024

Uh oh!

ocpdocs-previewbot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Missxiaoguo commented Jul 19, 2024

Uh oh!

amolnar-rh commented Jul 31, 2024

Uh oh!

dfitzmau commented Jul 31, 2024

Uh oh!

dfitzmau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Aug 1, 2024

Uh oh!

Uh oh!

josclark42 commented Aug 12, 2024

Uh oh!

openshift-ci-robot commented Aug 13, 2024

Uh oh!

amolnar-rh commented Aug 13, 2024

Uh oh!

bhardesty commented Aug 13, 2024

Uh oh!

bhardesty left a comment

Choose a reason for hiding this comment

Uh oh!

bhardesty Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

bhardesty Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

bhardesty Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

amolnar-rh Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

bhardesty Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

bhardesty commented Aug 13, 2024

Uh oh!

openshift-ci bot commented Aug 14, 2024

Uh oh!

amolnar-rh commented Aug 14, 2024

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 14, 2024

Uh oh!

jab-rh commented Aug 14, 2024

Uh oh!

jab-rh commented Aug 14, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 14, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 14, 2024

Uh oh!

Uh oh!

amolnar-rh commented Jul 18, 2024 •

edited

Loading

ocpdocs-previewbot commented Jul 18, 2024 •

edited

Loading