Skip to content

OSDOCS-11452: refactor Getting started title MicroShift #79405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

OSDOCS-11452: refactor Getting started title MicroShift #79405

merged 1 commit into from
Jul 31, 2024

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Jul 24, 2024 •
edited
Loading

Version(s):
4.17+

Issue:
OSDOCS-11452

Link to docs preview:
Understanding MicroShift refactor

QE review:

  • N/A internal docs work; no technical content changes

Additional information:
ContentX_cy24
To peer reviewers: No content has changed in this PR. Re-org only.
Note that the Splash page determines the category. That change does not show in the preview here.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2024 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-11452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11452

Link to docs preview:

QE review:

  • N/A internal docs work; no technical content changes

Additional information:
Note that the Splash page determines the major title. That change is elsewhere and does not show in the preview here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jul 24, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2024
@openshift openshift deleted a comment from openshift-ci bot Jul 24, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 24, 2024 •
edited
Loading

🤖 Wed Jul 31 18:33:48 - Prow CI generated the docs preview:
https://79405--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 25, 2024 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-11452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11452

Link to docs preview:
Understanding MicroShift refactor

QE review:

  • N/A internal docs work; no technical content changes

Additional information:
Note that the Splash page determines the major title. That change is elsewhere and does not show in the preview here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 25, 2024 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-11452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11452

Link to docs preview:
Understanding MicroShift refactor

QE review:

  • N/A internal docs work; no technical content changes

Additional information:
ContentX_cy24
Note that the Splash page determines the major title. That change is elsewhere and does not show in the preview here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link

We need to discuss this and reach an agreement on general direction.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@ShaunaDiaz ShaunaDiaz added peer-review-needed Signifies that the peer review team needs to review this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2024 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-11452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11452

Link to docs preview:
Understanding MicroShift refactor

QE review:

  • N/A internal docs work; no technical content changes

Additional information:
ContentX_cy24
To peer reviewers: No content has changed in this PR. Re-org only.
Note that the Splash page determines the category. That change does not show in the preview here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 31, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 31, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 31, 2024
View reviewed changes
@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 31, 2024
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-11452 branch 2 times, most recently from 5d297d7 to e31656b Compare July 31, 2024 15:48
GroceryBoyJr
GroceryBoyJr reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

@ShaunaDiaz nice work! I note the "Red Hat build of MicroShift release notes" goes to the included "hey don't put your release notes here" page, which is, I expect, normal.

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 31, 2024
@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 31, 2024
@ShaunaDiaz ShaunaDiaz added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 31, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 31, 2024
jldohmann
jldohmann reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing before merge, otherwise LGTM

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 31, 2024

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 818041e into openshift:main Jul 31, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #79789

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldohmann jldohmann jldohmann left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @ggiguash @GroceryBoyJr @openshift-cherrypick-robot @jldohmann @ocpdocs-vale-bot