Skip to content

OCPBUGS-35480:updates prerequisites for OVN-K migration #79716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

OCPBUGS-35480:updates prerequisites for OVN-K migration #79716

merged 1 commit into from
Jul 31, 2024

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Jul 30, 2024 •
edited
Loading

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-35840

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 30, 2024
@openshift-ci-robot
Copy link

@JoeAldinger: This pull request references Jira Issue OCPBUGS-35480, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Jul 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 30, 2024 •
edited
Loading

🤖 Wed Jul 31 19:42:40 - Prow CI generated the docs preview:

https://79716--ocpdocs-pr.netlify.app/
https://79716--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html

@anuragthehatter
Copy link

cc @weliang1 @zhaozhanqi PTAL

@weliang1
Copy link

@JoeAldinger Do we have a bug for this new statement?
Before migration to OVN-Kubernetes, set all timeouts for webhooks to 3 seconds or remove them.

@JoeAldinger
Copy link
Contributor Author

@JoeAldinger Do we have a bug for this new statement? Before migration to OVN-Kubernetes, set all timeouts for webhooks to 3 seconds or remove them.

Yes, it is linked above.

@JoeAldinger JoeAldinger added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 30, 2024
@weliang1
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@dfitzmau
Copy link
Contributor

/label peer-review-needed

/label peer-review-in-progress

dfitzmau
dfitzmau reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress

/label peer-review-done

@dfitzmau
Copy link
Contributor

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 30, 2024

@dfitzmau: Those labels are not set on the issue: peer-review-in-progress

In response to this:

/remove-label peer-review-in-progress

/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 31, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 31, 2024

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoeAldinger JoeAldinger merged commit 05e9773 into openshift:main Jul 31, 2024
2 checks passed
@JoeAldinger JoeAldinger deleted the OCPBUGS-35840 branch July 31, 2024 20:44
@openshift-ci-robot
Copy link

@JoeAldinger: Jira Issue OCPBUGS-35480 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-35840

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.17

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.16

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #79797

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 31, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #79798

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 31, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: #79716 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-35480:updates prerequisites for OVN-K migration
Using index info to reconstruct a base tree...
M	modules/nw-ovn-kubernetes-migration.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ovn-kubernetes-migration.adoc
CONFLICT (content): Merge conflict in modules/nw-ovn-kubernetes-migration.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-35480:updates prerequisites for OVN-K migration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@JoeAldinger: #79716 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-35480:updates prerequisites for OVN-K migration
Using index info to reconstruct a base tree...
M	modules/nw-ovn-kubernetes-migration.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ovn-kubernetes-migration.adoc
CONFLICT (content): Merge conflict in modules/nw-ovn-kubernetes-migration.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-35480:updates prerequisites for OVN-K migration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoeAldinger
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@JoeAldinger: Jira Issue OCPBUGS-35480 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weliang1 weliang1 mentioned this pull request Mar 20, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitzmau dfitzmau dfitzmau left review comments

Assignees

@weliang1 weliang1

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@JoeAldinger @openshift-ci-robot @ocpdocs-previewbot @anuragthehatter @weliang1 @dfitzmau @openshift-cherrypick-robot