Skip to content

OCPBUGS-37364: Detail unsupported routes for the External DNS Operator #79724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

OCPBUGS-37364: Detail unsupported routes for the External DNS Operator #79724

merged 1 commit into from
Aug 1, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 30, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 30, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-37364, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 30, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2024
@openshift-ci-robot
Copy link

@dfitzmau: An error was encountered adding this pull request to the external tracker bugs for bug OCPBUGS-37364 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. failed to get remote links: You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

Version(s):
4.12

Issues:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 30, 2024 •
edited
Loading

🤖 Thu Aug 01 08:06:43 - Prow CI generated the docs preview:

https://79724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.html
https://79724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/external_dns_operator/external-dns-operator-release-notes.html
https://79724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/external_dns_operator/nw-creating-dns-records-on-azure.html
https://79724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/external_dns_operator/nw-creating-dns-records-on-gcp.html

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-37364, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.12+

Issues:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-37364 branch 2 times, most recently from 796a5f0 to a5bd22b Compare July 30, 2024 16:06
@lihongan
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 31, 2024
@openshift-ci-robot
Copy link

@lihongan: This pull request references Jira Issue OCPBUGS-37364, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan July 31, 2024 08:19
@dfitzmau dfitzmau force-pushed the OCPBUGS-37364 branch 6 times, most recently from fa15db2 to 99d66dd Compare July 31, 2024 11:00
@lihongan
Copy link

LGTM. thank you @dfitzmau

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 31, 2024
knobunc
knobunc approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Srivaralakshmi Srivaralakshmi added lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 1, 2024
@Srivaralakshmi Srivaralakshmi merged commit 168171a into openshift:main Aug 1, 2024
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-37364 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.12+

Issues:

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.12

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.13

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.14

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.15

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.16

@Srivaralakshmi
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: #79724 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-37364: Detail unsupported routes for the External DNS Operator
.git/rebase-apply/patch:33: trailing whitespace.
The External DNS Operator deploys and manages `ExternalDNS` to provide name resolution for services and routes from the external DNS provider to {product-title}. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	networking/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.adoc
A	networking/external_dns_operator/external-dns-operator-release-notes.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): networking/external_dns_operator/external-dns-operator-release-notes.adoc deleted in HEAD and modified in OCPBUGS-37364: Detail unsupported routes for the External DNS Operator. Version OCPBUGS-37364: Detail unsupported routes for the External DNS Operator of networking/external_dns_operator/external-dns-operator-release-notes.adoc left in tree.
Auto-merging networking/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-37364: Detail unsupported routes for the External DNS Operator
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: #79724 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-37364: Detail unsupported routes for the External DNS Operator
.git/rebase-apply/patch:33: trailing whitespace.
The External DNS Operator deploys and manages `ExternalDNS` to provide name resolution for services and routes from the external DNS provider to {product-title}. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	networking/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.adoc
A	networking/external_dns_operator/external-dns-operator-release-notes.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): networking/external_dns_operator/external-dns-operator-release-notes.adoc deleted in HEAD and modified in OCPBUGS-37364: Detail unsupported routes for the External DNS Operator. Version OCPBUGS-37364: Detail unsupported routes for the External DNS Operator of networking/external_dns_operator/external-dns-operator-release-notes.adoc left in tree.
Auto-merging networking/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-37364: Detail unsupported routes for the External DNS Operator
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 1, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #79822

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 1, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #79823

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #79824

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 1, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #79825

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 1, 2024
Merged
@Srivaralakshmi
Copy link
Contributor

@dfitzmau Please share the manual CP PR links for the 4.12 and 4.13 branches. I will review and merge them.

This was referenced Aug 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldohmann jldohmann jldohmann left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@knobunc knobunc knobunc approved these changes

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@knobunc knobunc

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @lihongan @Srivaralakshmi @openshift-cherrypick-robot @knobunc @jldohmann