Skip to content

OCPBUGS-32929_2#correcting a command #79820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

OCPBUGS-32929_2#correcting a command #79820

merged 1 commit into from
Aug 14, 2024

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Aug 1, 2024 •
edited
Loading

@brendan-daly-red-hat brendan-daly-red-hat changed the title OCPBUGS-32929#correcting a command OCPBUGS-32929_2#correcting a command Aug 1, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 1, 2024 •
edited
Loading

🤖 Fri Aug 02 10:28:23 - Prow CI generated the docs preview:

https://79820--ocpdocs-pr.netlify.app/openshift-dedicated/latest/openshift_images/samples-operator-alt-registry.html
https://79820--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-installation-images.html
https://79820--ocpdocs-pr.netlify.app/openshift-enterprise/latest/openshift_images/samples-operator-alt-registry.html
https://79820--ocpdocs-pr.netlify.app/openshift-rosa/latest/openshift_images/samples-operator-alt-registry.html

@brendan-daly-red-hat
Copy link
Contributor Author

@gpei, PTAL at this draft update. Please also confirm what version this update applies to (e.g., 4.13+, 4.15+, etc.).

@gpei
Copy link

gpei commented Aug 2, 2024

Sorry, I can't ack this update, because the --insecure=true parameter is just an optional one, it's only required when the host doesn't trust the CA cert that signs the mirror registry, I'll suggest to add a note like the one in

https://docs.openshift.com/container-platform/4.15/installing/disconnected_install/installing-mirroring-installation-images.html#olm-mirror-catalog-airgapped_installing-mirroring-installation-images

--insecure \ ④

④ Optional: If you do not want to configure trust for the target registry, add the --insecure flag.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 2, 2024

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

Sorry, I can't ack this update, because the --insecure=true parameter is just an optional one, it's only required when the host doesn't trust the CA cert that signs the mirror registry, I'll suggest to add a note like the one in

https://docs.openshift.com/container-platform/4.15/installing/disconnected_install/installing-mirroring-installation-images.html#olm-mirror-catalog-airgapped_installing-mirroring-installation-images

--insecure \ ④

④ Optional: If you do not want to configure trust for the target registry, add the --insecure flag.

@gpei, Thanks for your suggestion. PTAL at the revised draft. Also, does this update apply to 4.15+?

@brendan-daly-red-hat brendan-daly-red-hat mentioned this pull request Aug 2, 2024
Closed
1 task
@gpei
Copy link

gpei commented Aug 5, 2024

@brendan-daly-red-hat It looks good to me, thanks for the update.

does this update apply to 4.15+?

yes

@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 9, 2024
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 9, 2024
xenolinux
xenolinux reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 9, 2024
@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 14, 2024
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 14, 2024
@jab-rh jab-rh added this to the Continuous Release milestone Aug 14, 2024
@jab-rh jab-rh merged commit fc24bf4 into openshift:main Aug 14, 2024
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Aug 14, 2024

/cherry-pick enterprise-4.17

@jab-rh
Copy link
Contributor

jab-rh commented Aug 14, 2024

/cherry-pick enterprise-4.16

@jab-rh
Copy link
Contributor

jab-rh commented Aug 14, 2024

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 14, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #80480

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #80481

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Aug 14, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #80482

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jab-rh jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@brendan-daly-red-hat @ocpdocs-previewbot @gpei @xenolinux @jab-rh @openshift-cherrypick-robot