Skip to content

OSDOCS#10853: Remove unsupported overcommit methods from Managed docs #80040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

OSDOCS#10853: Remove unsupported overcommit methods from Managed docs #80040

merged 1 commit into from
Oct 9, 2024

Conversation

laubai
Copy link
Contributor

@laubai laubai commented Aug 6, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2024
@laubai
Copy link
Contributor Author

laubai commented Aug 6, 2024

/test all

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 6, 2024 •
edited
Loading

🤖 Wed Oct 09 05:11:07 - Prow CI generated the docs preview:

https://80040--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/clusters/nodes-cluster-overcommit.html
https://80040--ocpdocs-pr.netlify.app/openshift-dedicated/latest/support/troubleshooting/sd-managed-resources.html
https://80040--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-overcommit.html
https://80040--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/node-tasks.html
https://80040--ocpdocs-pr.netlify.app/openshift-rosa/latest/nodes/clusters/nodes-cluster-overcommit.html
https://80040--ocpdocs-pr.netlify.app/openshift-rosa/latest/support/troubleshooting/sd-managed-resources.html

@laubai laubai force-pushed the osdocs-10853-remove-unsupported-kubeletconfig branch 2 times, most recently from 85484a7 to db052e4 Compare September 9, 2024 02:51
@laubai
Copy link
Contributor Author

laubai commented Sep 9, 2024

/test all

@laubai laubai changed the title [DRAFT] OSDOCS#10853: Remove unsupported overcommit methods from Managed docs OSDOCS#10853: Remove unsupported overcommit methods from Managed docs Sep 9, 2024
@laubai laubai marked this pull request as ready for review September 9, 2024 03:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@laubai laubai force-pushed the osdocs-10853-remove-unsupported-kubeletconfig branch 3 times, most recently from 8ad7ec1 to 5bed257 Compare September 19, 2024 10:26
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@lyman9966
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@laubai
Copy link
Contributor Author

laubai commented Sep 24, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 24, 2024
@lpettyjo lpettyjo self-requested a review September 24, 2024 13:22
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 branch/enterprise-4.17 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 24, 2024
@lpettyjo lpettyjo added this to the Continuous Release milestone Sep 24, 2024
lpettyjo
lpettyjo reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 24, 2024
@laubai
Copy link
Contributor Author

laubai commented Sep 25, 2024

/labels merge-review-needed

@laubai
Copy link
Contributor Author

laubai commented Sep 26, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 26, 2024
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 26, 2024
xenolinux
xenolinux reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and a YAML rendering issue to consider before merging - otherwise LGTM!

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 26, 2024
@laubai laubai force-pushed the osdocs-10853-remove-unsupported-kubeletconfig branch 2 times, most recently from 63420d9 to 435acf0 Compare September 30, 2024 11:39
@laubai
Copy link
Contributor Author

laubai commented Sep 30, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 30, 2024
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 1, 2024
@mburke5678
Copy link
Contributor

@laubai One PR-related question I am hoping you could address before merging. And one non-PR question you can answer whenever.

@laubai laubai force-pushed the osdocs-10853-remove-unsupported-kubeletconfig branch from 435acf0 to c525c14 Compare October 9, 2024 04:51
@laubai
Copy link
Contributor Author

laubai commented Oct 9, 2024

@mburke5678 This should be good to go when you're back online :)

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Oct 9, 2024
View reviewed changes
support/troubleshooting/sd-managed-resources.adoc
@@ -9,7 +9,7 @@ toc::[]
[id="sd-managed-resources-overview_{context}"]
== Overview

The following covers all resources managed or protected by the Service Reliability Engineering Platform (SRE-P) Team. Customers should not attempt to modify these resources because doing so can lead to cluster instability.
The following covers all {product-title} resources that are managed or protected by the Service Reliability Engineering Platform (SRE-P) Team. Customers should not attempt to modify these resources because doing so can lead to cluster instability.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.Spacing: Keep one space between words in 'Team. Customers'. For more information, see RedHat.Spacing.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 9, 2024

@laubai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 merged commit a3272e9 into openshift:main Oct 9, 2024
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.17

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #83260

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #83261

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #83262

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@xenolinux xenolinux xenolinux left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@lyman9966 lyman9966

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@laubai @ocpdocs-previewbot @lyman9966 @mburke5678 @openshift-cherrypick-robot @xenolinux @lpettyjo @ocpdocs-vale-bot @bergerhoffer