Skip to content

OSDOCS-7359: aggregate relevant information #80182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

OSDOCS-7359: aggregate relevant information #80182

merged 1 commit into from
Aug 15, 2024

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Aug 7, 2024 •
edited
Loading

@jldohmann jldohmann added this to the Continuous Release milestone Aug 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-7359

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-7359

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann
Copy link
Contributor Author

@melvinjoseph86 could you PTAL at this docs PR for QE ack? thank you

@jldohmann
Copy link
Contributor Author

/retest

@ocpdocs-previewbot
Copy link

🤖 Wed Aug 07 19:47:06 - Prow CI generated the docs preview:

https://80182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring-ipfailover.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 7, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-7359

Link to docs preview: https://80182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring-ipfailover.html#nw-ipfailover-cluster-ha-ingress_configuring-ipfailover

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 7, 2024
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 8, 2024
xenolinux
xenolinux reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 8, 2024
@melvinjoseph86
Copy link

melvinjoseph86 commented Aug 12, 2024 •
edited
Loading

Hi @jldohmann i am fine with the changes. but i can see there is some issue (no page found) in the link doc of [Configuration for ExternalIP](https://github.com/openshift/openshift-docs/blob/fd879eee91e7501fc8ec4702a963b48187b09c1d/networking/configuring_ingress_cluster_traffic/configuring-externalip.adoc#configuration-externalip_configuring-externalip)

the below 3 Prerequisites files are giving 'page not found' error even in the main branch.

[modules/nw-externalip-about.adoc](https://github.com/openshift/openshift-docs/blob/fd879eee91e7501fc8ec4702a963b48187b09c1d/networking/configuring_ingress_cluster_traffic/modules/nw-externalip-about.adoc)

[modules/nw-externalip-object.adoc](https://github.com/openshift/openshift-docs/blob/fd879eee91e7501fc8ec4702a963b48187b09c1d/networking/configuring_ingress_cluster_traffic/modules/nw-externalip-object.adoc)

[modules/nw-externalip-configuring.adoc](https://github.com/openshift/openshift-docs/blob/fd879eee91e7501fc8ec4702a963b48187b09c1d/networking/configuring_ingress_cluster_traffic/modules/nw-externalip-configuring.adoc)

@jldohmann
Copy link
Contributor Author

thanks @melvinjoseph86 ! that happens for modules for some reason when attempting to view them through their associated include statements in github, but their sections are included in the assembly at build time: https://docs.openshift.com/container-platform/4.16/networking/configuring_ingress_cluster_traffic/configuring-externalip.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-7359

Link to docs preview: https://80182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring-ipfailover.html#nw-ipfailover-cluster-ha-ingress_configuring-ipfailover

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann merged commit 3e9862f into openshift:main Aug 15, 2024
2 checks passed
@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.17

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.16

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.14

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.13

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80557

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80558

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Aug 15, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80559

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80560

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80561

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #80562

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2024
Merged
@jldohmann jldohmann deleted the OSDOCS-7359 branch August 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@jldohmann @openshift-ci-robot @ocpdocs-previewbot @xenolinux @melvinjoseph86 @openshift-cherrypick-robot