Point to a single place describing how to create secrets #8020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
lgtm |
|
thanks @soltysh ! |
bmcelvee
reviewed
Mar 6, 2018
dev_guide/managing_images.adoc
Outdated
| $ oc create secret docker-registry --help | ||
| ---- | ||
| To configure this, you need to create a xref:../dev_guide/secrets.adoc#dev-guide-secrets[secret], | ||
| which is used to store your credentials. See xref:#allowing-pods-to-reference-images-from-other-secured-registries[here] |
There was a problem hiding this comment.
Thanks, @soltysh! Would you mind changing this sentence to the following or something similar? Otherwise, LGTM.
"See xref:#allowing-pods-to-reference-images-from-other-secured-registries[Allowing Pods to Reference Images from Other Secured Registries] for instructions on creating a secret using oc create secret command."
|
@bmcelvee updated, ptal |
|
Thanks, @soltysh! LGTM 🌞 |
|
No revision history necessary. |
This was referenced Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bparees and I talked about it shortly on IRC, instead of having two out of sync places we've decided to create a single place an link from the other.
@openshift/team-documentation ptal