Skip to content

HCIDOCS-441: Update sandboxed containers attributes #80397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Aug 13, 2024

Removed unused OpenShift Sandboxed containers attributes.

Updated remaining attribute to align with OSC docs attributes.

(The Vale rule for OCP SuggestAttributes will be fixed in a separate PR)

Version(s): 4.16+

Issue: HCIDOCS-441

Link to docs preview: preview

QE review: NA

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024

@apinnick: This pull request references HCIDOCS-441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Removed unused attributes.
Updated remaining attribute to align with OSC docs attributes.

Version(s):

Issue: HCIDOCS-441

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apinnick apinnick added this to the Continuous Release milestone Aug 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024

@apinnick: This pull request references HCIDOCS-441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Removed unused attributes.
Updated remaining attribute to align with OSC docs attributes.

Version(s): 4.16+

Issue: HCIDOCS-441

Link to docs preview:

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 13, 2024

🤖 Tue Aug 13 14:14:58 - Prow CI generated the docs preview:
https://80397--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024

@apinnick: This pull request references HCIDOCS-441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Removed unused attributes.
Updated remaining attribute to align with OSC docs attributes.

Version(s): 4.16+

Issue: HCIDOCS-441

Link to docs preview: preview

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024

@apinnick: This pull request references HCIDOCS-441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Removed unused OpenShift Sandboxed containers attributes.

Updated remaining attribute to align with OSC docs attributes.

(The Vale rule for OCP SuggestAttributes will be fixed in a separate PR)

Version(s): 4.16+

Issue: HCIDOCS-441

Link to docs preview: preview

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apinnick apinnick added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 13, 2024
Removed unused OpenShift sandboxed containers attributes.

Updated remaining attribute to align with OSC docs attributes.
@apinnick apinnick force-pushed the sandboxed-containers-attribute-cleanup branch from 24fbc49 to 17ebe05 Compare August 13, 2024 14:06
Copy link

openshift-ci bot commented Aug 13, 2024

@apinnick: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 14, 2024
@lahinson lahinson removed the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 14, 2024
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 14, 2024
@apinnick apinnick merged commit f8951c7 into openshift:main Aug 15, 2024
2 checks passed
@apinnick apinnick deleted the sandboxed-containers-attribute-cleanup branch August 15, 2024 09:17
@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.16

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@apinnick: new pull request created: #80519

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@apinnick: new pull request created: #80520

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.16 branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants