Organizes release notes content for OMR #80433

stevsmit · 2024-08-13T17:55:29Z

Be sure to check the preview!

Version(s):
4.11+

Issue:
Part of https://issues.redhat.com/browse/OSDOCS-11690

Link to docs preview:
https://80433--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-creating-registry.html#mirror-registry-release-notes_installing-mirroring-creating-registry

Content org. QE is not necessary.

Additional information:

ocpdocs-previewbot · 2024-08-13T17:59:18Z

🤖 Thu Aug 15 17:52:39 - Prow CI generated the docs preview:

https://80433--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-creating-registry.html

skopacz1

Just a few comments, otherwise LGTM!

modules/mirror-registry-release-notes.adoc

skopacz1 · 2024-08-14T15:54:13Z

modules/mirror-registry-release-notes.adoc

@@ -9,10 +9,13 @@ The _mirror registry for Red Hat OpenShift_ is a small and streamlined container

 These release notes track the development of the _mirror registry for Red Hat OpenShift_ in {product-title}.

-For an overview of the _mirror registry for Red Hat OpenShift_, see xref:../../installing/disconnected_install/installing-mirroring-creating-registry.adoc#mirror-registry-flags_installing-mirroring-creating-registry[Creating a mirror registry with mirror registry for Red Hat OpenShift].
+[id="mirror-registry-release-notes-1-3"]
+== Mirror registry for Red Hat OpenShift 1.3 release notes


Per the SSG there needs to be a non breaking space in between Red and Hat:

Suggested change

== Mirror registry for Red Hat OpenShift 1.3 release notes

== Mirror registry for Red{nbsp}Hat OpenShift 1.3 release notes

The nbsp should definitely be applied to this net-new heading. They should also probably be applied to the other headings you add an = to in this PR, but that would be slightly out of scope so that's up to you

skopacz1 · 2024-08-14T15:54:39Z

modules/mirror-registry-release-notes.adoc

+[id="mirror-registry-release-notes-1-3"]
+== Mirror registry for Red Hat OpenShift 1.3 release notes
+
+The following sections provide details for each 1.3.z release of the _mirror registry for Red Hat OpenShift_


Same comment as above:

Suggested change

The following sections provide details for each 1.3.z release of the _mirror registry for Red Hat OpenShift_

The following sections provide details for each 1.3.z release of the _mirror registry for Red{nbsp}Hat OpenShift_

modules/mirror-registry-release-notes.adoc

skopacz1 · 2024-08-14T16:06:07Z

modules/mirror-registry-release-notes.adoc


 * Previously, the following error could be returned when attempting to uninstall _mirror registry for Red Hat OpenShift_: `["Error: no container with name or ID \"quay-postgres\" found: no such container"], "stdout": "", "stdout_lines": []***`. With this update, the order that _mirror registry for Red Hat OpenShift_ services are stopped and uninstalled have been changed so that the error no longer occurs when uninstalling _mirror registry for Red Hat OpenShift_. For more information, see link:https://issues.redhat.com/browse/PROJQUAY-4629[*PROJQUAY-4629*].

+[id="mirror-registry-release-notes-1-2"]
+== Mirror registry for Red Hat OpenShift 1.2 release notes


Suggested change

== Mirror registry for Red Hat OpenShift 1.2 release notes

== Mirror registry for Red{nbsp}Hat OpenShift 1.2 release notes

skopacz1 · 2024-08-14T16:06:42Z

modules/mirror-registry-release-notes.adoc

+[id="mirror-registry-release-notes-1-2"]
+== Mirror registry for Red Hat OpenShift 1.2 release notes
+
+The following sections provide details for each 1.2.z release of the _mirror registry for Red Hat OpenShift_


Suggested change

The following sections provide details for each 1.2.z release of the _mirror registry for Red Hat OpenShift_

The following sections provide details for each 1.2.z release of the _mirror registry for Red{nbsp}Hat OpenShift_

skopacz1 · 2024-08-14T16:07:12Z

modules/mirror-registry-release-notes.adoc

+== Mirror registry for Red Hat OpenShift 1.1 release notes
+
+The following section provides details 1.1.0 release of the _mirror registry for Red Hat OpenShift_


Suggested change

== Mirror registry for Red Hat OpenShift 1.1 release notes

The following section provides details 1.1.0 release of the _mirror registry for Red Hat OpenShift_

== Mirror registry for Red{nbsp}Hat OpenShift 1.1 release notes

The following section provides details 1.1.0 release of the _mirror registry for Red{nbsp}Hat OpenShift_

openshift-ci · 2024-08-15T17:53:49Z

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

stevsmit · 2024-08-15T18:06:45Z

/cherry-pick enterprise-4.17

stevsmit · 2024-08-15T18:06:48Z

/cherry-pick enterprise-4.16

stevsmit · 2024-08-15T18:06:51Z

/cherry-pick enterprise-4.15

stevsmit · 2024-08-15T18:06:54Z

/cherry-pick enterprise-4.14

stevsmit · 2024-08-15T18:06:57Z

/cherry-pick enterprise-4.13

stevsmit · 2024-08-15T18:06:59Z

/cherry-pick enterprise-4.12

openshift-cherrypick-robot · 2024-08-15T18:07:37Z

@stevsmit: new pull request created: #80549

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-15T18:07:40Z

@stevsmit: new pull request created: #80550

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-15T18:07:44Z

@stevsmit: new pull request created: #80551

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-15T18:07:48Z

@stevsmit: new pull request created: #80552

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-15T18:07:53Z

@stevsmit: new pull request created: #80553

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-08-15T18:07:55Z

@stevsmit: #80433 failed to apply on top of branch "enterprise-4.12":

Applying: Organizes release notes content for OMR
Using index info to reconstruct a base tree...
M	modules/mirror-registry-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/mirror-registry-release-notes.adoc
CONFLICT (content): Merge conflict in modules/mirror-registry-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Organizes release notes content for OMR
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2024

stevsmit added branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 labels Aug 13, 2024

stevsmit added this to the Continuous Release milestone Aug 13, 2024

stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 13, 2024

skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 14, 2024

skopacz1 reviewed Aug 14, 2024

View reviewed changes

skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 14, 2024

Organizes release notes content for OMR

6434e04

stevsmit force-pushed the 11690-omr-release-note-reorg branch from 5762f39 to 6434e04 Compare August 15, 2024 17:42

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2024

stevsmit merged commit 14fe1be into openshift:main Aug 15, 2024
2 checks passed

openshift-cherrypick-robot mentioned this pull request Aug 15, 2024

[enterprise-4.17] Organizes release notes content for OMR #80549

Merged

openshift-cherrypick-robot mentioned this pull request Aug 15, 2024

[enterprise-4.16] Organizes release notes content for OMR #80550

Merged

openshift-cherrypick-robot mentioned this pull request Aug 15, 2024

[enterprise-4.15] Organizes release notes content for OMR #80551

Merged

openshift-cherrypick-robot mentioned this pull request Aug 15, 2024

[enterprise-4.14] Organizes release notes content for OMR #80552

Merged

openshift-cherrypick-robot mentioned this pull request Aug 15, 2024

[enterprise-4.13] Organizes release notes content for OMR #80553

Merged

	== Mirror registry for Red Hat OpenShift 1.3 release notes
	== Mirror registry for Red{nbsp}Hat OpenShift 1.3 release notes

	The following sections provide details for each 1.3.z release of the _mirror registry for Red Hat OpenShift_
	The following sections provide details for each 1.3.z release of the _mirror registry for Red{nbsp}Hat OpenShift_

		== Mirror registry for Red Hat OpenShift 1.1 release notes

		The following section provides details 1.1.0 release of the _mirror registry for Red Hat OpenShift_

Organizes release notes content for OMR #80433

Organizes release notes content for OMR #80433

Uh oh!

Conversation

stevsmit commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skopacz1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

skopacz1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

skopacz1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

skopacz1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

skopacz1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

skopacz1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Aug 15, 2024

Uh oh!

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

stevsmit commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

openshift-cherrypick-robot commented Aug 15, 2024

Uh oh!

Uh oh!

stevsmit commented Aug 13, 2024 •

edited

Loading

ocpdocs-previewbot commented Aug 13, 2024 •

edited

Loading