Skip to content

OSDOCS-11956: Multi-line Code Copy/Paste Incorrect #81582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Sep 10, 2024

OSDOCS-11956: Multi-line Code Copy/Paste Incorrect

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-11956

Link to docs preview:
https://81582--ocpdocs-pr.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/cloud-experts-aws-secret-manager.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024

@jneczypor: This pull request references OSDOCS-11956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

OSDOCS-11956: Multi-line Code Copy/Paste Incorrect

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-11956

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 10, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024

@jneczypor: This pull request references OSDOCS-11956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

OSDOCS-11956: Multi-line Code Copy/Paste Incorrect

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-11956

Link to docs preview:
https://81582--ocpdocs-pr.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/cloud-experts-aws-secret-manager.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jneczypor
Copy link
Contributor Author

Hi @paulczar - When you have a moment, can you please review this PR? Thanks!

Copy link

openshift-ci bot commented Sep 11, 2024

@jneczypor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EricPonvelle EricPonvelle merged commit 6b94e69 into openshift:main Sep 11, 2024
2 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #81647

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #81648

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.16 branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants