Skip to content

Fixed the new docs experience URL for ACS docs #85363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

gaurav-nelson
Copy link
Contributor

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 25, 2024

🤖 Wed Nov 27 08:20:46 - Prow CI generated the docs preview:

https://85363--ocpdocs-pr.netlify.app/

@aireilly
Copy link
Contributor

Looks good. Did you verify this in the build locally?

@gaurav-nelson
Copy link
Contributor Author

@aireilly I've added updated the PR to remove the banner from 4.18 as well. I haven't tested this locally.

Description of the image

Copy link

openshift-ci bot commented Nov 27, 2024

@gaurav-nelson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@aireilly aireilly merged commit 1be5931 into openshift:main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants