Skip to content

ALBO: Follow-up edits for #86081 #86576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

ALBO: Follow-up edits for #86081 #86576

merged 1 commit into from
Jan 7, 2025

Conversation

adellape
Copy link
Contributor

@adellape adellape commented Dec 20, 2024 •
edited
Loading

Minor follow-up edits for #86081 per discussion with @cowgirljessi.

4.16+

  • "Ingress" -> "ingress" for consistency
  • Change a TOC-level == Additional resources to a module-specific .Additional resource
  • Rm unused assembly files

Preview: https://86576--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/aws_load_balancer_operator/configuring-aws-load-balancer-operator.html#nw-creating-multiple-ingress-through-single-alb_aws-load-balancer-operator

@adellape adellape added this to the Continuous Release milestone Dec 20, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Dec 20 21:44:41 - Prow CI generated the docs preview:

https://86576--ocpdocs-pr.netlify.app/
https://86576--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/aws_load_balancer_operator/configuring-aws-load-balancer-operator.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 20, 2024

@adellape: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 20, 2024
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 23, 2024
snarayan-redhat
snarayan-redhat reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 23, 2024
@adellape adellape merged commit ea208d5 into openshift:main Jan 7, 2025
2 checks passed
@adellape
Copy link
Contributor Author

adellape commented Jan 7, 2025

/cherrypick enterprise-4.18

@adellape
Copy link
Contributor Author

adellape commented Jan 7, 2025

/cherrypick enterprise-4.17

@adellape
Copy link
Contributor Author

adellape commented Jan 7, 2025

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #86787

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #86788

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #86789

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@adellape @ocpdocs-previewbot @openshift-cherrypick-robot @snarayan-redhat