Skip to content

Updates UDN docs to include required NS label #86845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

Updates UDN docs to include required NS label #86845

merged 1 commit into from
Feb 14, 2025

Conversation

stevsmit
Copy link
Member

@stevsmit stevsmit commented Jan 9, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 9, 2025 •
edited
Loading

🤖 Fri Feb 14 14:45:26 - Prow CI generated the docs preview:

https://86845--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html

trozet
trozet reviewed Jan 22, 2025
View reviewed changes
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch from 8efc2db to 89ee31b Compare January 23, 2025 13:51
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch from addab0b to 961e164 Compare January 30, 2025 19:56
@stevsmit stevsmit added this to the Continuous Release milestone Jan 30, 2025
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch from 961e164 to 717c5cd Compare February 10, 2025 17:18
weliang1
weliang1 reviewed Feb 10, 2025
View reviewed changes
modules/nw-udn-benefits.adoc
Developers and administrators can create a user-defined network that is namespace scoped using the custom resource. An overview of the process is as follows:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pod created in the UDN namespace can be configured to have a default, primary, or secondary network. What does statement "This provides the flexibility of a secondary network to the primary network" (line 16) mean?

Copy link
Member Author

@stevsmit stevsmit Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weliang1 I didn't write this content. I did contact the original author, but he also wasn't sure exactly what we meant by this. We have a PR (https://github.com/openshift/openshift-docs/pull/87260/files) that expands on L2 and L3 information. I can get this sentence removed in a separate PR because it doesn't make sense.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weliang1 I didn't write this content. I did contact the original author, but he also wasn't sure exactly what we meant by this. We have a PR (https://github.com/openshift/openshift-docs/pull/87260/files) that expands on L2 and L3 information. I can get this sentence removed in a separate PR because it doesn't make sense.

@stevsmit Agree to remove line 16.

@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
@lpettyjo lpettyjo self-requested a review February 11, 2025 19:30
lpettyjo
lpettyjo reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

lpettyjo
lpettyjo reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that there are two commits. Please squash to one.

@lpettyjo lpettyjo added branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 11, 2025
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch 5 times, most recently from a34b8b7 to 823060f Compare February 13, 2025 15:21
ormergi
ormergi reviewed Feb 13, 2025
View reviewed changes
ormergi
ormergi reviewed Feb 13, 2025
View reviewed changes
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch from 823060f to 26da726 Compare February 13, 2025 15:41
@ormergi
Copy link

ormergi commented Feb 13, 2025

/assign @ormergi

@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch 2 times, most recently from f7971a8 to b74fdcd Compare February 14, 2025 14:04
Updates UDN docs to include required NS label
ad0e1d0 
Addresses ocpbugs48423--commit two
@stevsmit stevsmit force-pushed the udn-namespace-ocpbugs-48218 branch from b74fdcd to ad0e1d0 Compare February 14, 2025 14:28
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 14, 2025

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 6649910 into openshift:main Feb 14, 2025
2 checks passed
@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #88638

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet left review comments

@weliang1 weliang1 weliang1 left review comments

@ormergi ormergi ormergi left review comments

@anuragthehatter anuragthehatter anuragthehatter left review comments

@lpettyjo lpettyjo lpettyjo left review comments

Assignees

@ormergi ormergi

Labels
branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@stevsmit @ocpdocs-previewbot @ormergi @openshift-cherrypick-robot @trozet @weliang1 @anuragthehatter @lpettyjo