Skip to content

OSDOCS-13215: updating oc-mirror links #87822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

OSDOCS-13215: updating oc-mirror links #87822

merged 1 commit into from
Jan 31, 2025

Conversation

skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented Jan 29, 2025 •
edited
Loading

OSDOCS-13215

Version(s): 4.18+

This PR updates links to the oc-mirror v1 doc, wherever appropriate, with links to the v2 doc.

QE review:

  • QE has approved this change.

Previews (only listing a few for examples):

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-13215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

OSDOCS-13215

Version(s): 4.18+

This PR updates links to the oc-mirror v1 doc, wherever appropriate, with links to the v2 doc.

QE review:

  • QE has approved this change.

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Jan 29 21:55:26 - Prow CI generated the docs preview:
https://87822--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 29, 2025

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2025 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-13215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

OSDOCS-13215

Version(s): 4.18+

This PR updates links to the oc-mirror v1 doc, wherever appropriate, with links to the v2 doc.

QE review:

  • QE has approved this change.

Previews (only listing a few for examples):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lmzuccarelli
Copy link

@skopacz1 - Thanks for the updates. The changes look pretty straight forward to me.

I would like @kasturinarra to also have a look.

@kasturinarra
Copy link

@skopacz1 - Thanks for the updates. The changes look pretty straight forward to me.

I would like @kasturinarra to also have a look.

sure @lmzuccarelli will take a look.

@kasturinarra
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2025 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-13215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

OSDOCS-13215

Version(s): 4.18+

This PR updates links to the oc-mirror v1 doc, wherever appropriate, with links to the v2 doc.

QE review:

  • QE has approved this change.

Previews (only listing a few for examples):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skopacz1 skopacz1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 30, 2025
GroceryBoyJr
GroceryBoyJr reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 30, 2025
@skopacz1 skopacz1 added this to the Planned for 4.18 GA milestone Jan 31, 2025
@skopacz1 skopacz1 merged commit 328e788 into openshift:main Jan 31, 2025
2 checks passed
@skopacz1
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #87918

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 31, 2025
Merged
@skopacz1 skopacz1 deleted the OSDOCS-13215 branch March 11, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

Assignees

@kasturinarra kasturinarra

Labels
branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.18 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@skopacz1 @openshift-ci-robot @ocpdocs-previewbot @lmzuccarelli @kasturinarra @GroceryBoyJr @openshift-cherrypick-robot