Skip to content

TELCODOCS-2107 - CNF-13189 - Remove the internal API and sidecar support #88823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

TELCODOCS-2107 - CNF-13189 - Remove the internal API and sidecar support #88823

merged 1 commit into from
Mar 4, 2025

Conversation

slovern
Copy link
Contributor

@slovern slovern commented Feb 18, 2025 •
edited
Loading

[TELCODOCS-2107](https://issues.redhat.com//browse/TELCODOCS-2107) - [CNF-13189](https://issues.redhat.com//browse/CNF-13189) - Remove the internal API and sidecar support

Version(s): 4.19

Issue: https://issues.redhat.com/browse/TELCODOCS-2107

Link to docs preview: About PTP and clock synchronization error events

QE review: @Bonnie-Block

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 18, 2025 •
edited
Loading

🤖 Wed Feb 19 16:36:30 - Prow CI generated the docs preview:

https://88823--ocpdocs-pr.netlify.app/
https://88823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/about-ptp.html
https://88823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/configuring-ptp.html
https://88823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/ptp-cloud-events-consumer-dev-reference-v2.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2025
@slovern slovern force-pushed the TELCODOCS-2107 branch 2 times, most recently from 59b7cbf to 7a1768d Compare February 19, 2025 12:01
@slovern slovern force-pushed the TELCODOCS-2107 branch 2 times, most recently from c2acac5 to aef39db Compare February 19, 2025 14:19
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2025

@slovern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jzding
jzding approved these changes Feb 19, 2025
View reviewed changes
Copy link

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@Bonnie-Block
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2025

@Bonnie-Block: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slovern
Copy link
Contributor Author

slovern commented Mar 3, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 3, 2025
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2025
GroceryBoyJr
GroceryBoyJr reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 3, 2025
@slovern
Copy link
Contributor Author

slovern commented Mar 4, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 4, 2025
@slovern
Copy link
Contributor Author

slovern commented Mar 4, 2025

thanks for the review, @GroceryBoyJr

@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.19 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 4, 2025
@xenolinux xenolinux added this to the Planned for 4.19 GA milestone Mar 4, 2025
xenolinux
xenolinux reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging

@xenolinux xenolinux merged commit 371e041 into openshift:main Mar 4, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 4, 2025
@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #89516

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@slovern
Copy link
Contributor Author

slovern commented Mar 4, 2025

Thanks for merging @xenolinux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@jzding jzding jzding approved these changes

Assignees

@jzding jzding

Labels
branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@slovern @ocpdocs-previewbot @Bonnie-Block @GroceryBoyJr @xenolinux @openshift-cherrypick-robot @jzding @ocpdocs-vale-bot