-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Sanitize openshift_master_cluster_hostname #8908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
openshift_master_cluster_hostname should point to the internal LB or internal master hostname. Having the same values in this and in the public URL leads to installation errors and missconfigurations.
@wanghaoran1988, does this change look ok to you? |
@kalexand-rh LGTM, thanks |
/cherrypick enterprise-3.10 |
@kalexand-rh: new pull request created: #9018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.9 |
@kalexand-rh: new pull request created: #9019 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.8 |
@kalexand-rh: cannot checkout enterprise-3.8: error checking out enterprise-3.8: exit status 1. output: error: pathspec 'enterprise-3.8' did not match any file(s) known to git. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.7 |
@kalexand-rh: new pull request created: #9020 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.6 |
@kalexand-rh: new pull request created: #9021 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.5 |
@kalexand-rh: new pull request created: #9022 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.4 |
@kalexand-rh: new pull request created: #9023 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.3 |
@kalexand-rh: new pull request created: #9024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift_master_cluster_hostname should point to
the internal LB or internal master hostname.
Having the same values in this and in the public URL
leads to installation errors and missconfigurations.