Skip to content

Sanitize openshift_master_cluster_hostname #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2018
Merged

Sanitize openshift_master_cluster_hostname #8908

merged 1 commit into from
May 3, 2018

Conversation

fbac
Copy link

@fbac fbac commented Apr 26, 2018

openshift_master_cluster_hostname should point to
the internal LB or internal master hostname.
Having the same values in this and in the public URL
leads to installation errors and missconfigurations.

openshift_master_cluster_hostname should point to
the internal LB or internal master hostname.
Having the same values in this and in the public URL
leads to installation errors and missconfigurations.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2018
@kalexand-rh
Copy link
Contributor

@wanghaoran1988, does this change look ok to you?

@kalexand-rh kalexand-rh self-assigned this May 2, 2018
@wanghaoran1988
Copy link
Member

@kalexand-rh LGTM, thanks

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9018

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9019

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.8

@openshift-cherrypick-robot

@kalexand-rh: cannot checkout enterprise-3.8: error checking out enterprise-3.8: exit status 1. output: error: pathspec 'enterprise-3.8' did not match any file(s) known to git.

In response to this:

/cherrypick enterprise-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9020

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.6

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9021

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.5

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9022

In response to this:

/cherrypick enterprise-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.4

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9023

In response to this:

/cherrypick enterprise-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.3

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #9024

In response to this:

/cherrypick enterprise-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fbac fbac deleted the fix-masterurl branch May 3, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants