Skip to content

CNV#56500: [Docs] Incorrect yaml for HostPathProvisioner #89234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

CNV#56500: [Docs] Incorrect yaml for HostPathProvisioner #89234

merged 1 commit into from
Mar 4, 2025

Conversation

aspauldi
Copy link

@aspauldi aspauldi commented Feb 26, 2025 •
edited
Loading

Version(s): 4.17+

Issue: CNV-56500

Link to docs preview: Creating a hostpath provisioner with a basic storage pool

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2025
@aspauldi
Copy link
Author

/label CNV

@openshift-ci openshift-ci bot added the CNV Label for all CNV PRs label Feb 26, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Feb 26 19:00:41 - Prow CI generated the docs preview:

https://89234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/storage/virt-configuring-local-storage-with-hpp.html
https://89234--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/storage/virt-configuring-local-storage-with-hpp.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2025

@aspauldi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ShellyKa13
ShellyKa13 reviewed Feb 27, 2025
View reviewed changes
Copy link

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2025
@dalia-frank
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 2, 2025

@dalia-frank: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aspauldi
Copy link
Author

aspauldi commented Mar 3, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 3, 2025
@eohartman
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 3, 2025
GroceryBoyJr
GroceryBoyJr reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2025
@GroceryBoyJr
Copy link
Contributor

Woops, sorry @eohartman

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-done

@openshift-ci openshift-ci bot removed the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 3, 2025
@eohartman
Copy link
Contributor

Formatting change looks great!

@eohartman
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 3, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 3, 2025

@eohartman: Those labels are not set on the issue: peer-review-needed

In response to this:

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aspauldi
Copy link
Author

aspauldi commented Mar 3, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 3, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 4, 2025
xenolinux
xenolinux reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging

@xenolinux xenolinux merged commit a0d2187 into openshift:main Mar 4, 2025
2 checks passed
@xenolinux xenolinux added branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Mar 4, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Mar 4, 2025
@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.19

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #89502

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #89503

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #89504

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ShellyKa13 ShellyKa13 ShellyKa13 left review comments

Assignees

@ShellyKa13 ShellyKa13

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@aspauldi @ocpdocs-previewbot @dalia-frank @eohartman @GroceryBoyJr @xenolinux @openshift-cherrypick-robot @ShellyKa13