Skip to content

OSDOCS-13287: adds RHOAI to MicroShift #89987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Mar 10, 2025

Version(s):
4.19+

Issue:
OSDOCS-13287

Link to docs preview:
microshift-rhoai

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release note PR, #91557
Install PR, #91558

@ShaunaDiaz ShaunaDiaz added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2025
@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.19 GA milestone Mar 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@ShaunaDiaz: This pull request references OSDOCS-13287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@ShaunaDiaz: This pull request references OSDOCS-13287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2025
@ShaunaDiaz ShaunaDiaz removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 10, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@ShaunaDiaz: This pull request references OSDOCS-13287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-13287

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 10, 2025

🤖 Wed Apr 16 18:53:13 - Prow CI generated the docs preview:
https://89987--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
@openshift-ci openshift-ci bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link

openshift-ci bot commented Apr 15, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, let me know if you have any questions. Otherwise LGTM, awesome work with such a huge PR and docs addition!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 15, 2025
@ShaunaDiaz ShaunaDiaz added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-13287 branch 2 times, most recently from 5eac721 to 79032b1 Compare April 15, 2025 17:51
@openshift openshift deleted a comment from openshift-ci bot Apr 15, 2025
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@openshift openshift deleted a comment from openshift-ci bot Apr 15, 2025
@ShaunaDiaz ShaunaDiaz added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-13287 branch 2 times, most recently from 35fe932 to ed6dc24 Compare April 16, 2025 12:33
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 16, 2025
@ShaunaDiaz
Copy link
Contributor Author

/retest

1 similar comment
@ShaunaDiaz
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Apr 16, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz added merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 17, 2025
@ShaunaDiaz ShaunaDiaz merged commit 9ecb5b5 into openshift:main Apr 17, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@ShaunaDiaz: #89987 failed to apply on top of branch "enterprise-4.19":

Applying: OSDOCS-13287: adds RHOAI to MicroShift
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-13287: adds RHOAI to MicroShift

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.