Skip to content

OCPBUGS-53001: Fixing partition size notation #90144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

OCPBUGS-53001: Fixing partition size notation #90144

merged 1 commit into from
Mar 12, 2025

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Mar 12, 2025 •
edited
Loading

OCPBUGS-53001: Fixing partition size notation... it should be the wonderfully named "gibibyte" with the notation GiB in regular text.

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-53001

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 12, 2025
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-53001, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-53001: Fixing partition size notation... it should be the wonderfully named "gibibyte" with the notation GiB in regular text.

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-53001

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Mar 12 14:22:30 - Prow CI generated the docs preview:

https://90144--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_base_install/ibi-factory-image-based-install.html

trewest
trewest approved these changes Mar 12, 2025
View reviewed changes
Copy link

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-53001, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-53001: Fixing partition size notation... it should be the wonderfully named "gibibyte" with the notation GiB in regular text.

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-53001

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2025
@opayne1 opayne1 added this to the Continuous Release milestone Mar 12, 2025
opayne1
opayne1 reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without double checking a preview everything looks good to me!

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 12, 2025
@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 12, 2025
@mburke5678
Copy link
Contributor

/retest

@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 12, 2025
@mburke5678 mburke5678 merged commit b407f8d into openshift:main Mar 12, 2025
2 checks passed
@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-53001 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-53001: Fixing partition size notation... it should be the wonderfully named "gibibyte" with the notation GiB in regular text.

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-53001

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.17

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.18

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #90169

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 12, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #90170

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 12, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #90171

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opayne1 opayne1 opayne1 left review comments

@trewest trewest trewest approved these changes

Assignees

@trewest trewest

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @openshift-cherrypick-robot @trewest @opayne1