Skip to content

OADP-5817: Removed incorrect information regarding SSE-C Encryption #90702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

OADP-5817: Removed incorrect information regarding SSE-C Encryption #90702

merged 1 commit into from
Mar 20, 2025

Conversation

apurvabhide17
Copy link
Contributor

@apurvabhide17 apurvabhide17 commented Mar 19, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@apurvabhide17: This pull request references OADP-5817 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.14 - 4.18

Issue:
OADP-5817

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
@apurvabhide17
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Mar 19, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Mar 19 17:43:17 - Prow CI generated the docs preview:

https://90702--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@apurvabhide17: This pull request references OADP-5817 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.14 - 4.18

Issue:
OADP-5817

Link to docs preview: https://90702--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html#oadp-ssec-encrypted-backups_installing-oadp-aws

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2025

@apurvabhide17: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shdeshpa07
shdeshpa07 reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@shdeshpa07 shdeshpa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

stillalearner
stillalearner approved these changes Mar 20, 2025
View reviewed changes
Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apurvabhide17
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2025 •
edited by openshift-ci bot
Loading

@apurvabhide17: This pull request references OADP-5817 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.14 - 4.18

Issue:
OADP-5817

Link to docs preview: https://90702--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html#oadp-ssec-encrypted-backups_installing-oadp-aws

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 20, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Mar 20, 2025
xenolinux
xenolinux reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 20, 2025
@apurvabhide17
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 20, 2025
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 20, 2025
sheriff-rh
sheriff-rh approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@sheriff-rh sheriff-rh merged commit c30d6ff into openshift:main Mar 20, 2025
2 checks passed
@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.19

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.18

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.17

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.16

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90781

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90783

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90784

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90786

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90787

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #90788

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@shdeshpa07 shdeshpa07 shdeshpa07 left review comments

@kaovilai kaovilai kaovilai approved these changes

@stillalearner stillalearner stillalearner approved these changes

@sheriff-rh sheriff-rh sheriff-rh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@apurvabhide17 @openshift-ci-robot @ocpdocs-previewbot @sheriff-rh @openshift-cherrypick-robot @kaovilai @stillalearner @xenolinux @shdeshpa07