Skip to content

[OSDOCS-13712]: Replacing AWS STS credentials in HCP docs #90734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

[OSDOCS-13712]: Replacing AWS STS credentials in HCP docs #90734

merged 1 commit into from
Mar 20, 2025

Conversation

lahinson
Copy link
Contributor

@lahinson lahinson commented Mar 19, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
@lahinson lahinson added this to the Continuous Release milestone Mar 19, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Mar 19 20:31:40 - Prow CI generated the docs preview:

https://90734--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2025

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jparrill
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@jiezhao16
Copy link

lgtm

@lahinson lahinson added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 20, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 20, 2025
xenolinux
xenolinux reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 20, 2025
@lahinson lahinson merged commit 0284e1b into openshift:main Mar 20, 2025
2 checks passed
@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.17

@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.18

@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #90801

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #90802

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #90803

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees

@jparrill jparrill

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@lahinson @ocpdocs-previewbot @jparrill @jiezhao16 @openshift-cherrypick-robot @xenolinux