Skip to content

[OCPBUGS#53460] Fix the oc patch command for the global ip forwarding in cno docs #90929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

[OCPBUGS#53460] Fix the oc patch command for the global ip forwarding in cno docs #90929

merged 1 commit into from
Mar 28, 2025

Conversation

Skalador
Copy link
Contributor

@Skalador Skalador commented Mar 21, 2025 •
edited by lahinson
Loading

The oc patch command for global ipForwarding was missing a single quote at the end and a --type=merge to be applied to any cluster.

Version(s):

4.16 - 4.18

Issue:

https://issues.redhat.com/browse/OCPBUGS-53460

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@Skalador
Fix the oc patch command for the global ip forwarding in cno docs
9cd1ec8 
The oc patch command for global ipForwarding was missing a single quote at the end and a --type=merge to be applied to any cluster.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2025
@Skalador
Copy link
Contributor Author

Tagging as per PR guidelines @openshift/team-documentation
Tagging @anuragthehatter for QA

jeana-redhat
jeana-redhat approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 21, 2025
@jeana-redhat jeana-redhat added this to the Continuous Release milestone Mar 21, 2025
@ocpdocs-previewbot
Copy link

🤖 Fri Mar 21 19:35:46 - Prow CI generated the docs preview:

https://90929--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/cluster-network-operator.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2025

@Skalador: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anuragthehatter
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
lahinson
lahinson reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for merge review.

@lahinson lahinson merged commit c387e78 into openshift:main Mar 28, 2025
2 checks passed
@lahinson
Copy link
Contributor

/cherrypick enterprise-4.16

@lahinson
Copy link
Contributor

/cherrypick enterprise-4.17

@lahinson
Copy link
Contributor

/cherrypick enterprise-4.18

@lahinson
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91252

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91253

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91254

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91255

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@anuragthehatter anuragthehatter

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@Skalador @ocpdocs-previewbot @anuragthehatter @lahinson @openshift-cherrypick-robot @jeana-redhat