Skip to content

OCPBUGS-54352 Default value seems to be set to false for the parameter enableInjector and enableOperatorWebhook #91315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

OCPBUGS-54352 Default value seems to be set to false for the parameter enableInjector and enableOperatorWebhook #91315

merged 1 commit into from
Mar 31, 2025

Conversation

kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Mar 31, 2025 •
edited
Loading

[OCPBUGS-54352]: Default value seems to be set to false for the parameters enableInjector and enableOperatorWebhook in SriovOperatorConfig.spec.

Version(s): 4.16+

Issue:https://issues.redhat.com/browse/OCPBUGS-54352

Link to docs preview:https://91315--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/sr-iov-operator/configuring-sriov-operator.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 31, 2025 •
edited
Loading

🤖 Mon Mar 31 16:16:20 - Prow CI generated the docs preview:

https://91315--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/sr-iov-operator/configuring-sriov-operator.html

@kquinn1204 kquinn1204 changed the title OCPBUGS-54352 Default value seems to be set to false for the paramete… OCPBUGS-54352 Default value seems to be set to false for the parameter enableInjector and enableOperatorWebhook Mar 31, 2025
@kquinn1204
Copy link
Contributor Author

@gkopels can you review this change applies from 4.16 and greater I believe. Once they had to set value in CR it needs explicitly set.

zeeke
zeeke reviewed Mar 31, 2025
View reviewed changes
Copy link

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
@kquinn1204
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 31, 2025
@kquinn1204
Copy link
Contributor Author

@evgenLevin can you please review from QE perspective

evgenLevin
evgenLevin approved these changes Mar 31, 2025
View reviewed changes
Copy link

@evgenLevin evgenLevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 31, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Mar 31, 2025
@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 31, 2025
@stevsmit
Copy link
Member

lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 31, 2025

New changes are detected. LGTM label has been removed.

@kquinn1204
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 31, 2025

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 31, 2025
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 31, 2025
@stevsmit stevsmit merged commit 7afae8d into openshift:main Mar 31, 2025
2 checks passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.16

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.17

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.18

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #91349

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2025
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #91350

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2025
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #91351

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2025
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #91352

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2025
Merged
@dfitzmau dfitzmau mentioned this pull request Apr 7, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke left review comments

@evgenLevin evgenLevin evgenLevin approved these changes

Assignees

@zeeke zeeke

@evgenLevin evgenLevin

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@kquinn1204 @ocpdocs-previewbot @stevsmit @openshift-cherrypick-robot @zeeke @evgenLevin