Skip to content

[OSDOCS-13848]: Add must-gather docs for day 2 HCP #91355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

[OSDOCS-13848]: Add must-gather docs for day 2 HCP #91355

merged 1 commit into from
Apr 3, 2025

Conversation

lahinson
Copy link
Contributor

@lahinson lahinson commented Mar 31, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 31, 2025 •
edited
Loading

🤖 Thu Apr 03 15:05:43 - Prow CI generated the docs preview:

https://91355--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-troubleshooting.html

@lahinson lahinson added this to the Continuous Release milestone Apr 1, 2025
@jiezhao16
Copy link

lgtm

@lahinson lahinson force-pushed the osdocs-13848-hcp-day-2-must-gather branch from 32f71f0 to 755d3db Compare April 2, 2025 14:01
lahinson
lahinson commented Apr 2, 2025
View reviewed changes
modules/hcp-must-gather-day-2.adoc Outdated

You can gather {product-title} debugging information for a hosted cluster by using the {mce-short} web console or by using the `hcp` CLI.

.Prerequisites
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roke/Vedant: Do these prerequisites apply to this procedure? I copied them from https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html-single/hosted_control_planes/index#hosted-control-planes-troubleshooting_hcp-troubleshooting.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@lahinson lahinson changed the title [OSDOCS-13848]: Add must gather docs for day 2 HCP [OSDOCS-13848]: Add must-gather docs for day 2 HCP Apr 2, 2025
rokej
rokej reviewed Apr 2, 2025
View reviewed changes
modules/hcp-must-gather-day-2.adoc Outdated
$ oc adm must-gather
----

* To collect must-gather information by using the `hcp` CLI, complete the following steps:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove hcp since the following steps run both hcp and oc commands.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

modules/hcp-must-gather-day-2.adoc Outdated

You can gather {product-title} debugging information for a hosted cluster by using the {mce-short} web console or by using the `hcp` CLI.

.Prerequisites
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@lahinson lahinson force-pushed the osdocs-13848-hcp-day-2-must-gather branch from 755d3db to fe2d97c Compare April 2, 2025 16:45
@jiezhao16
Copy link

lgtm

@lahinson lahinson added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 2, 2025
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2025
GroceryBoyJr
GroceryBoyJr reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See modularization request per each procedure, web console vs. CLI.

hosted_control_planes/hcp-troubleshooting.adoc
* xref:../hosted_control_planes/hcp-prepare/hcp-cli.adoc[Installing the {hcp} command-line interface]

include::modules/hcp-must-gather-day-2.adoc[leveloffset=+1]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the web console procedure in it's own module and the CLI in it's own module and include: both from the assembly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good reminder. Will do! Thank you @GroceryBoyJr!

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 2, 2025
@lahinson lahinson force-pushed the osdocs-13848-hcp-day-2-must-gather branch from fe2d97c to 7a5358c Compare April 3, 2025 14:57
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 3, 2025

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson merged commit 3268015 into openshift:main Apr 3, 2025
2 checks passed
@lahinson
Copy link
Contributor Author

lahinson commented Apr 3, 2025

/cherrypick enterprise-4.19

@lahinson
Copy link
Contributor Author

lahinson commented Apr 3, 2025

/cherrypick enterprise-4.18

@lahinson
Copy link
Contributor Author

lahinson commented Apr 3, 2025

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91588

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: new pull request created: #91589

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2025
Merged
@openshift-cherrypick-robot
Copy link

@lahinson: #91355 failed to apply on top of branch "enterprise-4.17":

Applying: Add must gather docs for day 2 HCP
Using index info to reconstruct a base tree...
M	hosted_control_planes/hcp-troubleshooting.adoc
Falling back to patching base and 3-way merge...
Auto-merging hosted_control_planes/hcp-troubleshooting.adoc
CONFLICT (content): Merge conflict in hosted_control_planes/hcp-troubleshooting.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add must gather docs for day 2 HCP

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lahinson lahinson mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@rokej rokej rokej approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@lahinson @ocpdocs-previewbot @jiezhao16 @GroceryBoyJr @openshift-cherrypick-robot @rokej