OSDOCS-12804#Increase vSphere max vols per node #91472
Conversation
openshift-ci
bot
added
the
size/M
lpettyjo
added
the
peer-review-needed
|
🤖 Tue Apr 01 19:37:22 - Prow CI generated the docs preview: |
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
stevsmit
added
the
peer-review-in-progress
| .Limitations | ||
| * You must be running VMware vSphere version 8 or later. | ||
| * You must have an homogeneous vSphere 8 environment that only contains ESXi 8 hypervisors. Heterogeneous environment that contain a mix of ESXi 7 and 8 are not allowed. |
There was a problem hiding this comment.
Should environment be plural here?
| * You must have an homogeneous vSphere 8 environment that only contains ESXi 8 hypervisors. Heterogeneous environment that contain a mix of ESXi 7 and 8 are not allowed. | |
| * You must have an homogeneous vSphere 8 environment that only contains ESXi 8 hypervisors. Heterogeneous environments that contain a mix of ESXi 7 and 8 are not allowed. |
| However, for vSphere version 8 or later, you can increase the allowable number of volumes per node to a maximum of 255. Otherwise, the default value remains at 59. | ||
|
|
||
| .Limitations | ||
| * You must be running VMware vSphere version 8 or later. |
There was a problem hiding this comment.
Just food for thought: is this really a limitation? Or a prerequisite?
I do think that the next bullet point is a limitation. 👍
| = Increasing the maximum allowable volumes per node for vSphere | ||
|
|
||
| .Prerequisites | ||
| * Access to the {product-title} web console. |
There was a problem hiding this comment.
If you find that having "* You must be running VMware vSphere version 8 or later." is more of a prerequisite, you could move it here.
| .Procedure | ||
|
|
||
| To increase the maximum number of volumes per node for vSphere: |
There was a problem hiding this comment.
Could this be moved to line 9 and revised as maybe something like:
| To increase the maximum number of volumes per node for vSphere: | |
| Use the following procedure to increase the maximum number of volumes per node for vSphere. |
That way we have an introductory sentence under the heading.
| include::modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc[leveloffset=+1] | ||
|
|
||
| :FeatureName: Increasing volumes per node | ||
| include::snippets/technology-preview.adoc[leveloffset=+2] |
There was a problem hiding this comment.
I'm hesitant to say that you should create a "Limitations" module for 1-2 limitations, but I can't help but wonder if the snippet would look better under the overview, and not under "Limitations." I guess TP could technically be a limitation, though (even though having it listed under "Limitations" might not be your intention).
stevsmit
added
peer-review-done
|
Nice work! |
stevsmit
removed
the
peer-review-needed
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/OSDOCS-12804
Link to docs preview: https://91472--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-increase-max-vols-per-node-overview_persistent-storage-csi-vsphere
QE review:
Additional information:
PTAL: @gcharot @RomanBednar @radeore