Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loki-deployment-sizing.adoc #91475

Closed
wants to merge 1 commit into from

Conversation

kiranrpatil12
Copy link
Contributor

@kiranrpatil12 kiranrpatil12 commented Apr 1, 2025

1x.demo Total disk requests if using the ruler is 80Gi but it is 60Gi.

Version(s):

RHOCP 4.12, RHOCP4.13 and RHOCP 4.14

Issue:

Link to docs preview:

https://issues.redhat.com/browse/OBSDOCS-1781

QE review:

  • QE has approved this change.

Additional information:

1x.demo Total disk requests if using the ruler is 80Gi but it is 60Gi.
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
Copy link

openshift-ci bot commented Apr 1, 2025

Hi @kiranrpatil12. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kiranrpatil12
Copy link
Contributor Author

/test all

Copy link

openshift-ci bot commented Apr 1, 2025

@kiranrpatil12: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kiranrpatil12
Copy link
Contributor Author

/test all

@kiranrpatil12
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 1, 2025
@skopacz1
Copy link
Contributor

skopacz1 commented Apr 1, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
Copy link

openshift-ci bot commented Apr 1, 2025

@kiranrpatil12: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Apr 2, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kiranrpatil12 FYI: When a PR is opened against main, the update applies till the latest version. For example in this case, 4.12 - 4.19. You can also mention it as 4.12+.

Please get the QE approval on this PR and add the preview link in comment 0.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 2, 2025
@kiranrpatil12
Copy link
Contributor Author

@xenolinux Actually, the branch gets changed from 4.14+, and I have opened PR for it separately.

@kiranrpatil12
Copy link
Contributor Author

@anpingli @QiaolingTang, kindly provide QE approval for this change. Thank you.

@anpingli
Copy link

anpingli commented Apr 3, 2025

LGTM

@kiranrpatil12
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 3, 2025
@agantony agantony removed the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 3, 2025
@agantony
Copy link
Contributor

agantony commented Apr 3, 2025

Merge review in progress

@agantony
Copy link
Contributor

agantony commented Apr 3, 2025

@xenolinux Actually, the branch gets changed from 4.14+, and I have opened PR for it separately.

@kiranrpatil12 We will not able to merge this PR. You need to create separate PRs for 4.12-4.13. I will close this PR.

@agantony agantony closed this Apr 3, 2025
@kiranrpatil12
Copy link
Contributor Author

@agantony This applies to versions 4.12 through 4.14. Starting from version 4.15, the branch changes due to a new logging version. Therefore, I have opened a separate PR for versions 4.15 to 4.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants