-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loki-deployment-sizing.adoc #91475
Conversation
1x.demo Total disk requests if using the ruler is 80Gi but it is 60Gi.
Hi @kiranrpatil12. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
@kiranrpatil12: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
/label peer-review-needed |
/ok-to-test |
@kiranrpatil12: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@kiranrpatil12 FYI: When a PR is opened against main
, the update applies till the latest version. For example in this case, 4.12 - 4.19. You can also mention it as 4.12+.
Please get the QE approval on this PR and add the preview link in comment 0.
@xenolinux Actually, the branch gets changed from 4.14+, and I have opened PR for it separately. |
@anpingli @QiaolingTang, kindly provide QE approval for this change. Thank you. |
LGTM |
/label merge-review-needed |
Merge review in progress |
@kiranrpatil12 We will not able to merge this PR. You need to create separate PRs for 4.12-4.13. I will close this PR. |
@agantony This applies to versions 4.12 through 4.14. Starting from version 4.15, the branch changes due to a new logging version. Therefore, I have opened a separate PR for versions 4.15 to 4.19. |
1x.demo Total disk requests if using the ruler is 80Gi but it is 60Gi.
Version(s):
RHOCP 4.12, RHOCP4.13 and RHOCP 4.14Issue:
Link to docs preview:
https://issues.redhat.com/browse/OBSDOCS-1781QE review:
Additional information: